fix!: update post-condition names for non-fungible tokens

BREAKING CHANGE: Post-conditions for NFTs were renamed to be more clear: `Owns` to `Sends`, `DoesNotOwn` to `DoesNotSend`.
hirosystems · Sep 30, 2022 · 9fbdcea · 9fbdcea
1 parent fc7e50c
commit 9fbdcea
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/packages/bns/src/index.ts b/packages/bns/src/index.ts
@@ -708,7 +708,7 @@ export async function buildTransferNameTx({
   ];
   const postConditionSender = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotOwn,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -717,7 +717,7 @@ export async function buildTransferNameTx({
   );
   const postConditionReceiver = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Owns,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),

diff --git a/packages/bns/tests/bns.test.ts b/packages/bns/tests/bns.test.ts
@@ -709,7 +709,7 @@ test('transferName', async () => {
   const { namespace, name } = decodeFQN(fullyQualifiedName);
   const nameTransferPostConditionOne = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotOwn,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -718,7 +718,7 @@ test('transferName', async () => {
   );
   const nameTransferPostConditionTwo = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Owns,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -777,7 +777,7 @@ test('transferName optionalArguments', async () => {
   const { namespace, name } = decodeFQN(fullyQualifiedName);
   const nameTransferPostConditionOne = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotOwn,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -786,7 +786,7 @@ test('transferName optionalArguments', async () => {
   );
   const nameTransferPostConditionTwo = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Owns,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),

diff --git a/packages/transactions/README.md b/packages/transactions/README.md
@@ -475,7 +475,7 @@ import {
 
 // With a standard principal
 const postConditionAddress = 'SP2ZD731ANQZT6J4K3F5N8A40ZXWXC1XFXHVVQFKE';
-const postConditionCode = NonFungibleConditionCode.Owns;
+const postConditionCode = NonFungibleConditionCode.Sends;
 const assetAddress = 'SP62M8MEFH32WGSB7XSF9WJZD7TQB48VQB5ANWSJ';
 const assetContractName = 'test-asset-contract';
 const assetName = 'test-asset';

diff --git a/packages/transactions/src/constants.ts b/packages/transactions/src/constants.ts
@@ -126,8 +126,8 @@ enum FungibleConditionCode {
 }
 
 enum NonFungibleConditionCode {
-  DoesNotOwn = 0x10,
-  Owns = 0x11,
+  DoesNotSend = 0x10,
+  Sends = 0x11,
 }
 
 enum PostConditionPrincipalID {

diff --git a/packages/transactions/tests/builder.test.ts b/packages/transactions/tests/builder.test.ts
@@ -870,14 +870,14 @@ test('Make contract-call with post conditions', async () => {
     ),
     makeStandardNonFungiblePostCondition(
       postConditionAddress,
-      NonFungibleConditionCode.Owns,
+      NonFungibleConditionCode.Sends,
       info,
       bufferCVFromString(tokenAssetName)
     ),
     makeContractNonFungiblePostCondition(
       postConditionAddress,
       contractName,
-      NonFungibleConditionCode.DoesNotOwn,
+      NonFungibleConditionCode.DoesNotSend,
       info,
       bufferCVFromString(tokenAssetName)
     ),

diff --git a/packages/transactions/tests/postcondition.test.ts b/packages/transactions/tests/postcondition.test.ts
@@ -87,7 +87,7 @@ test('Non-fungible post condition serialization and deserialization', () => {
   const contractName = 'contract-name';
   const principal = createContractPrincipal(address, contractName);
 
-  const conditionCode = NonFungibleConditionCode.Owns;
+  const conditionCode = NonFungibleConditionCode.Sends;
 
   const assetAddress = 'SP2ZP4GJDZJ1FDHTQ963F0292PE9J9752TZJ68F21';
   const assetContractName = 'contract_name';
@@ -124,7 +124,7 @@ test('Non-fungible post condition with string IDs serialization and deserializat
   const address = 'SP2JXKMSH007NPYAQHKJPQMAQYAD90NQGTVJVQ02B';
   const contractName = 'contract-name';
 
-  const conditionCode = NonFungibleConditionCode.Owns;
+  const conditionCode = NonFungibleConditionCode.Sends;
 
   const assetAddress = 'SP2ZP4GJDZJ1FDHTQ963F0292PE9J9752TZJ68F21';
   const assetContractName = 'contract_name';