fix: rename incorrect nft post-condition codes

hirosystems · Oct 19, 2022 · 9fed6a4 · 9fed6a4 · vercel · Oct 19, 2022
1 parent 1e053e4
commit 9fed6a4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/bns/src/index.ts b/packages/bns/src/index.ts
@@ -708,7 +708,7 @@ export async function buildTransferNameTx({
   ];
   const postConditionSender = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotSend,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -717,7 +717,7 @@ export async function buildTransferNameTx({
   );
   const postConditionReceiver = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Sends,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),

diff --git a/packages/bns/tests/bns.test.ts b/packages/bns/tests/bns.test.ts
@@ -709,7 +709,7 @@ test('transferName', async () => {
   const { namespace, name } = decodeFQN(fullyQualifiedName);
   const nameTransferPostConditionOne = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotSend,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -718,7 +718,7 @@ test('transferName', async () => {
   );
   const nameTransferPostConditionTwo = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Sends,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -777,7 +777,7 @@ test('transferName optionalArguments', async () => {
   const { namespace, name } = decodeFQN(fullyQualifiedName);
   const nameTransferPostConditionOne = createNonFungiblePostCondition(
     publicKeyToAddress(getAddressVersion(network), createStacksPublicKey(publicKey)),
-    NonFungibleConditionCode.DoesNotSend,
+    NonFungibleConditionCode.Sends,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),
@@ -786,7 +786,7 @@ test('transferName optionalArguments', async () => {
   );
   const nameTransferPostConditionTwo = createNonFungiblePostCondition(
     newOwnerAddress,
-    NonFungibleConditionCode.Sends,
+    NonFungibleConditionCode.DoesNotSend,
     parseAssetInfoString(`${getBnsContractAddress(network)}.bns::names`),
     tupleCV({
       name: bufferCVFromString(name),

diff --git a/packages/transactions/README.md b/packages/transactions/README.md
@@ -475,7 +475,7 @@ import {
 
 // With a standard principal
 const postConditionAddress = 'SP2ZD731ANQZT6J4K3F5N8A40ZXWXC1XFXHVVQFKE';
-const postConditionCode = NonFungibleConditionCode.Sends;
+const postConditionCode = NonFungibleConditionCode.DoesNotSend;
 const assetAddress = 'SP62M8MEFH32WGSB7XSF9WJZD7TQB48VQB5ANWSJ';
 const assetContractName = 'test-asset-contract';
 const assetName = 'test-asset';