Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javascript without package manager docs #560

Closed
moxiegirl opened this issue Nov 1, 2018 · 12 comments
Closed

Add javascript without package manager docs #560

moxiegirl opened this issue Nov 1, 2018 · 12 comments
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests good first issue Appropriate for a new open source contribution

Comments

@moxiegirl
Copy link

@markmhx wrote on Slack:

I didn't even realize this was possible through our own documentation, had to google search to find the forum post where someone asked https://forum.blockstack.org/t/how-can-i-import-blockstack-js-as-a-script-without-using-a-package-manager/5881/3

Blockstack Forum
How can I import blockstack.js as a script without using a package manager?
Yes! You can download blockstack.js from the dist folder and use it without npm! https://github.com/blockstack/blockstack.js/tree/master/dist This is how we use it in both our ruby blockstack omniauth strategy and blockstack-android libraries. I added an issue to update our readme and make this more clear! Thank you for the feedback!!! #517
Aug 2nd

But my sense is that letting someone play around with blockstack via a web-based code editor like CodePen (already prepopulated with some starter code?) could be very potent

@moxiegirl moxiegirl self-assigned this Nov 1, 2018
@moxiegirl moxiegirl removed their assignment Nov 1, 2018
@moxiegirl moxiegirl added the good first issue Appropriate for a new open source contribution label Nov 1, 2018
@moxiegirl
Copy link
Author

@markmhx I've put this up as good first task in case a contributor wants to pick it up. But it is labeled docs so also on my todo.

@moxiegirl moxiegirl changed the title Add jsavacript without package manager docs Add javascript without package manager docs Nov 5, 2018
@tpscrpt
Copy link

tpscrpt commented Nov 29, 2018

@moxiegirl @markmhx I've setup a AWS CodeBuild trigger which gets master and compiles a .min.js every hour. The result can be found at https://s3.amazonaws.com/minifyjs/blockstack/blockstack.min.js

@tpscrpt
Copy link

tpscrpt commented Nov 29, 2018

#567 (comment)

@aulneau
Copy link
Contributor

aulneau commented Nov 29, 2018

Hey @JeremiGendron! Thanks for the changes you're suggesting.

I think a better solution would be that we during our build process we publish a minified version to NPM, and then suggest people use a service like https://unpkg.com/#/ to get access to that. It has the advantage of mirroring npm and also is most likely a service that won't go down.

@tpscrpt
Copy link

tpscrpt commented Nov 29, 2018

@aulneau Ok, I'll check it out

@markmhendrickson
Copy link

@JeremiGendron Thanks for taking the initiative here!

@tpscrpt
Copy link

tpscrpt commented Nov 29, 2018

@markmhx Thank you! I have some questions about the scripts which would be appropriate. Currently, I have it setup so the build script now transpiles and uglifies, which yields both dist/.es5.js and dist/.min.js. Would you like the prepublishOnly script to be different from the build script? Or is build only used when publishing?

@tpscrpt
Copy link

tpscrpt commented Nov 29, 2018

https://unpkg.com/demo-blockstack-dist is my attempt. I can still customize the package.json scripts if you want something more modular.

@markmhendrickson
Copy link

@JeremiGendron I'm not familiar with the scripts that have been set up for this repo, but at a glance, it appears that the prepublishOnly script is effectively an alias for build?

@aulneau Thoughts on @JeremiGendron's unkpg build above?

@moxiegirl moxiegirl added enhancement Iterations/refactor on existing features/infrastructure/tests and removed documentation labels Jan 4, 2019
@moxiegirl
Copy link
Author

moxiegirl commented Jan 14, 2019

@JeremiGendron Apologies for the slow reply. This slipped through my email. I'll take a look at this and see if we can't move it along. Thank you so much for the PR

@moxiegirl moxiegirl self-assigned this Jan 14, 2019
@tpscrpt
Copy link

tpscrpt commented Jan 14, 2019 via email

@zone117x
Copy link
Member

zone117x commented Aug 7, 2019

This is done and live.

@zone117x zone117x closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Iterations/refactor on existing features/infrastructure/tests good first issue Appropriate for a new open source contribution
Projects
None yet
Development

No branches or pull requests

6 participants