Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release ci #1181

Merged
merged 6 commits into from
Feb 23, 2022
Merged

update release ci #1181

merged 6 commits into from
Feb 23, 2022

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Feb 9, 2022

scope

comments

might be a bit hard to "test" and require a few tries

based on

@janniks janniks self-assigned this Feb 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1181 (72c7a7a) into master (a42a29b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   64.53%   64.53%           
=======================================
  Files         122      122           
  Lines        8333     8333           
  Branches     1535     1535           
=======================================
  Hits         5378     5378           
  Misses       2847     2847           
  Partials      108      108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42a29b...72c7a7a. Read the comment docs.

@janniks janniks added the chore label Feb 9, 2022
@janniks janniks marked this pull request as ready for review February 9, 2022 15:31
@janniks janniks added this to 💻 In development in stacks.js via automation Feb 16, 2022
@janniks janniks marked this pull request as draft February 16, 2022 13:32
@janniks janniks marked this pull request as ready for review February 23, 2022 12:30
@janniks janniks removed this from 💻 In development in stacks.js Feb 23, 2022
Copy link
Contributor

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no more semantic release?

@janniks
Copy link
Collaborator Author

janniks commented Feb 23, 2022

Kind of — semantic-release had been disabled on stacks.js for a while, since it seemed to not work well with lerna.

I believe that lerna now supports everything we need from semantic-release out-of-the-box.

@janniks janniks merged commit 6151441 into master Feb 23, 2022
@janniks janniks deleted the lerna-release-ci branch February 23, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing/release automation
3 participants