Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StacksNetworkName instead of union type #1500

Merged
merged 2 commits into from
May 17, 2023
Merged

Use StacksNetworkName instead of union type #1500

merged 2 commits into from
May 17, 2023

Conversation

friedger
Copy link
Collaborator

@friedger friedger commented May 17, 2023

This PR was published to npm with the version 6.5.4-pr.af5c701.0
e.g. npm install @stacks/common@6.5.4-pr.af5c701.0 --save-exact

Description

This PR replaces the duplicate union type for network names with StacksNetworkName

Breaking change

This PR requires an update of regtest network name to devnet or mocknet

Checklist

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 6:03pm

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changes for CI, I can commit and merge ☑️

packages/network/src/network.ts Outdated Show resolved Hide resolved
@janniks janniks merged commit efd2255 into master May 17, 2023
8 of 9 checks passed
@janniks janniks deleted the fix/1499 branch May 17, 2023 18:13
@friedger
Copy link
Collaborator Author

Thank you for the quick action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants