Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update AccountExtendedBalances interface #1521

Merged

Conversation

seromenho
Copy link
Contributor

@seromenho seromenho commented Jul 4, 2023

add lock_tx_id prop

Description

Fixes #1437
Adds the lock_tx_id property to the AccountExtendedBalances interface.

Checklist

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 1:41pm

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2023

CLA assistant check
All committers have signed the CLA.

@seromenho
Copy link
Contributor Author

Tagging @janniks to review. Thanks

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1521 (22bfbbf) into master (6cec371) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files         118      118           
  Lines        8631     8631           
  Branches     1906     1906           
=======================================
  Hits         5711     5711           
  Misses       2683     2683           
  Partials      237      237           
Impacted Files Coverage Δ
packages/stacking/src/index.ts 89.26% <ø> (ø)

@janniks
Copy link
Collaborator

janniks commented Jul 5, 2023

Thanks for the contribution 🙏

@janniks janniks merged commit 89dc787 into hirosystems:master Jul 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field in interface AccountExtendedBalances
4 participants