feat: implement isClarityType #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1597 +/- ##
==========================================
+ Coverage 66.18% 66.30% +0.12%
==========================================
Files 118 119 +1
Lines 8640 8677 +37
Branches 1908 1908
==========================================
+ Hits 5718 5753 +35
- Misses 2685 2799 +114
+ Partials 237 125 -112 ☔ View full report in Codecov by Sentry. |
zone117x
reviewed
Nov 26, 2023
janniks
approved these changes
Nov 27, 2023
|
|
||
| assert(isClarityType(vInt, ClarityType.Int)); | ||
| const intTest: IntCV = vInt; | ||
| intTest; // avoid the "value is never read warning" |
zone117x
approved these changes
Nov 27, 2023
Co-authored-by: janniks <6362150+janniks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a simple helper to narrow down the type of generic
ClarityValuesNot sure about the naming. I'm open to suggestions
Breaking change?
/
Example
Provided in the code
Checklist