Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] feat: switch to simple string private keys #1598

Merged
merged 2 commits into from Mar 11, 2024
Merged

[next] feat: switch to simple string private keys #1598

merged 2 commits into from Mar 11, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Nov 27, 2023

  • removes "wrapped" string private keys in favor of "flat" string/Uint8Array type aliases.
    • tldr: now we can just use string hex encoded private keys for all methods. before we often had to wrap with createStacksPrivateKey(...)

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 1:45pm

zone117x
zone117x approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a question around backwards compatibility. Seems like a good change to me 👍

@janniks janniks changed the title feat: switch to simple string private keys [next] feat: switch to simple string private keys Dec 14, 2023
@janniks
feat!: remove wrapped private key type
ced807a 
BREAKING CHANGE:
Remove wrapped `StacksPrivateKey` type in favor of simple type alias for string/Uint8Array.
@janniks
test: update bns tests
4795225
@janniks janniks force-pushed the feat/move-to-unwrapped-keys branch from 41e90f0 to 4795225 Compare March 11, 2024 13:43
@janniks janniks changed the base branch from feat/add-api-package to next March 11, 2024 13:44
@janniks janniks merged commit 9048a62 into next Mar 11, 2024
2 of 4 checks passed
@janniks janniks deleted the feat/move-to-unwrapped-keys branch March 11, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zone117x zone117x zone117x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janniks @zone117x