Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contract principal to ft index responses #180

Merged
merged 2 commits into from Aug 2, 2023
Merged

Conversation

rafaelcr
Copy link
Collaborator

@rafaelcr rafaelcr commented Aug 2, 2023

Description

Adds the contract_principal value to FT index responses. Also, fixes bug when filtering for name or symbol had no matches.

Example

{
  "decimals": 6,
  "description": "StackSwap Project",
  "image_canonical_uri": "https://app.stackswap.org/icon/stsw.svg",
  "image_uri": "https://app.stackswap.org/icon/stsw.svg",
  "name": "STACKSWAP",
  "sender_address": "SP1Z92MPDQEWZXW36VX71Q25HKF5K2EPCJ304F275",
  "symbol": "STSW",
  "token_uri": "https://app.stackswap.org/token/stsw.json",
  "total_supply": "1000000000000000",
  "tx_id": "0x3edffbd025ca2c29cfde8c583c0e0babacd4aa21075d10307d37c64ae78d579e",
  "contract_principal": "SP1Z92MPDQEWZXW36VX71Q25HKF5K2EPCJ304F275.stsw-token-v4a",
}

Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

@rafaelcr rafaelcr requested a review from He1DAr August 2, 2023 00:46
@rafaelcr rafaelcr temporarily deployed to Preview August 2, 2023 00:46 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Vercel deployment URL: https://token-metadata-34ac71rlp-blockstack.vercel.app 🚀

@rafaelcr rafaelcr linked an issue Aug 2, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #180 (fe78e93) into develop (540ac17) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #180      +/-   ##
===========================================
+ Coverage    84.72%   84.73%   +0.01%     
===========================================
  Files           52       52              
  Lines         5552     5556       +4     
  Branches       558      558              
===========================================
+ Hits          4704     4708       +4     
  Misses         838      838              
  Partials        10       10              
Files Changed Coverage Δ
src/api/routes/ft.ts 100.00% <100.00%> (ø)
src/api/schemas.ts 100.00% <100.00%> (ø)
src/pg/pg-store.ts 97.97% <100.00%> (ø)

Copy link

@He1DAr He1DAr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaelcr rafaelcr merged commit 57d0468 into develop Aug 2, 2023
7 checks passed
@rafaelcr rafaelcr deleted the fix/ft-list branch August 2, 2023 15:11
blockstack-devops pushed a commit that referenced this pull request Aug 2, 2023
## [0.5.0](v0.4.0...v0.5.0) (2023-08-02)

### Features

* add contract principal to ft index responses ([#180](#180)) ([57d0468](57d0468))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contract id to ft tokens response
3 participants