Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal <> hex value fix #604

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Conversation

karolzlot
Copy link
Contributor

I see that my e580 seems to behave in the same way, and I think this is a bug:

Author of this config probably wanted to set 80 as hex not as decimal

on my device this is what happens on exit:
hex 80 = dec 128 => factory auto mode
hex 50 = dec 80 => full speed of fan

I think author of config should confirm this before merge

I see that my e580 seems to behave in the same way, and I think this is a bug:

Author of this config probably wanted to set 80 as hex not as decimal

on my device this is what happens on exit:
hex 80 = dec 128 => factory auto mode
hex 50 = dec 80   => full speed of fan

I think author of config should confirm this before merge
@karolzlot
Copy link
Contributor Author

@svenlange2

Could you have a look at it? :-)

@svenlange2
Copy link
Contributor

For me (Thinkpad 13) both values seem to enable Factory Auto mode. Could not get full speed fan after exit with dec value of 128.

@karolzlot
Copy link
Contributor Author

Could you see what is default value of this field in Thinkpad 13?

I think these steps will work:

  1. Disable nbfc
  2. Set value any random value via RWEverything
  3. Turn off pc
  4. Turn on pc
  5. Read value by RWEverything (which should be set to default now)

@karolzlot
Copy link
Contributor Author

@svenlange2

@svenlange2
Copy link
Contributor

It is indeed hex 80. It is the next 2 bytes after the write register that are maxed out with this value (128). But I also must mention that on my laptop it is actually not important what the value is - it still works (auto mode). After reboot it is always hex 80 so I guess its safe to let it be 128 in the config then.

@karolzlot
Copy link
Contributor Author

@svenlange2
Thank you for checking this :-)

@hirschmann
This is ready to merge

@hirschmann
Copy link
Owner

Thanks to both of you for figuring this out :)

@hirschmann hirschmann merged commit e4299e3 into hirschmann:master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants