Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use itamae module instead of 'itamae/runner' #10

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Conversation

mataku
Copy link
Collaborator

@mataku mataku commented Jul 4, 2019

@hisaichi5518
Itamae v1.10.4 にアップデートしたら ichiba メソッドによるインスタンスのプロビジョニングが動かなくなったので直しに来ました

bundler: failed to load command: tenma (/repo/vendor/bundle/ruby/2.6.0/bin/tenma)
NoMethodError: undefined method `logger' for Itamae:Module
  /repo/vendor/bundle/ruby/2.6.0/gems/itamae-1.10.4/lib/itamae/runner.rb:8:in `run'
  /repo/vendor/bundle/ruby/2.6.0/gems/tenma-0.9.2/lib/tenma/ichiba/instance.rb:42:in `provision'
  /repo/vendor/bundle/ruby/2.6.0/gems/tenma-0.9.2/lib/tenma/ichiba/command.rb:22:in `execute'
  /repo/vendor/bundle/ruby/2.6.0/gems/tenma-0.9.2/lib/tenma/cli.rb:33:in `ichiba'
  /repo/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
  /repo/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
  /repo/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
  /repo/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
  /repo/vendor/bundle/ruby/2.6.0/gems/tenma-0.9.2/exe/tenma:5:in `<top (required)>'
  /repo/vendor/bundle/ruby/2.6.0/bin/tenma:23:in `load'
  /repo/vendor/bundle/ruby/2.6.0/bin/tenma:23:in `<top (required)>'

参考

itamae-kitchen/itamae@v1.10.3...v1.10.4

今までは require 'itamae' が各モジュール内にあったため名前解決できていたようでした。

本家をいじるか迷ったんですが itamae コマンドを使う前提 = require 'itamae' 作られているのと、require 'itamae' しとけば今後アップデートがあっても対応できそうだなということでこのようにしとります。

Copy link
Owner

@hisaichi5518 hisaichi5518 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hisaichi5518 hisaichi5518 merged commit db8a87f into master Jul 5, 2019
@hisaichi5518 hisaichi5518 deleted the require-itamae branch July 5, 2019 14:39
@hisaichi5518
Copy link
Owner

released〜〜 🚀 🚀 🚀 🚀
https://github.com/hisaichi5518/tenma/releases/tag/v0.9.3
https://rubygems.org/gems/tenma

@mataku
Copy link
Collaborator Author

mataku commented Jul 6, 2019

Thanks!!!!!!!!1!1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants