Fix concretecms#10595

hissy · May 6, 2022 · f11349a · f11349a
1 parent a57ddeb
commit f11349a
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/concrete/blocks/hero_image/controller.php b/concrete/blocks/hero_image/controller.php
@@ -105,7 +105,7 @@ public function edit()
         } elseif ($this->buttonFileLinkID) {
             $this->set('imageLinkHandle', 'file');
             $this->set('imageLinkValue', $this->buttonFileLinkID);
-        } elseif ((string) $this->buttonExternalLink !== '') {
+        } elseif ((string)$this->buttonExternalLink !== '') {
             $this->set('imageLinkHandle', 'external_url');
             $this->set('imageLinkValue', $this->buttonExternalLink);
         } else {
@@ -148,20 +148,19 @@ public function view()
 
         if ($this->buttonText || $this->getLinkURL()) {
 
-          $button = new Link($this->getLinkURL(), $this->buttonText);
-          $this->set('button', $button);
+            $button = new Link($this->getLinkURL(), $this->buttonText);
+            $this->set('button', $button);
+        }
 
-          $theme = Theme::getSiteTheme();
-          if ($theme && $theme->supportsFeature(Features::TYPOGRAPHY)) {
+        $theme = Theme::getSiteTheme();
+        if ($theme && $theme->supportsFeature(Features::TYPOGRAPHY)) {
             $this->set('theme', $theme);
-          }
-
-          $this->set('button', $button);
-          $this->set('linkURL', $this->getLinkURL());
-          $this->set('buttonIcon', $this->icon);
-          $this->set('iconTag', FontAwesomeIcon::getFromClassNames(h($this->icon)));
-          $this->set('titleFormat', $this->titleFormat ?? 'h1');
         }
+
+        $this->set('linkURL', $this->getLinkURL());
+        $this->set('buttonIcon', $this->icon);
+        $this->set('iconTag', FontAwesomeIcon::getFromClassNames(h($this->icon)));
+        $this->set('titleFormat', $this->titleFormat ?? 'h1');
     }
 
     public function validate($args)