Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test framework #20

Closed
hugoattal opened this issue Feb 15, 2022 · 2 comments · Fixed by #40
Closed

Add a test framework #20

hugoattal opened this issue Feb 15, 2022 · 2 comments · Fixed by #40
Assignees
@hugoattal
Labels
enhancement New feature or request ready to be implemented Design is done and implementation can be done in a PR

Comments

@hugoattal
Copy link
Collaborator

hugoattal commented Feb 15, 2022 •
edited
Loading

We should add a test framework, there are a lot of things that should be tested 😅

Suggestion: Peeky or Vitest
@hugoattal hugoattal added the enhancement New feature or request label Feb 15, 2022
@Akryum Akryum added the need spec Need Specs, UX or UI design... label Feb 18, 2022
@hugoattal
Copy link
Collaborator Author

@Akryum I think this is becoming critical as more and more features are shipped without proper testing.

I suggest we do it in 3 steps:

  • Add a unit test framework (let's go with peeky since you're behind it 😎)
  • Trigger it in GitHub action
  • Eventually add a E2E test framework like Cypress (maybe not needed right now)

Can we move forward with step 1? I'll just make a PR to add peeky and a few small tests to begin with.

@Akryum
Copy link
Member

Akryum commented Feb 18, 2022

👍

@Akryum Akryum added need spec Need Specs, UX or UI design... ready to be implemented Design is done and implementation can be done in a PR and removed need spec Need Specs, UX or UI design... labels Feb 18, 2022
@hugoattal hugoattal self-assigned this Feb 18, 2022
@hugoattal hugoattal mentioned this issue Feb 18, 2022
Merged
4 tasks
Akryum added a commit that referenced this issue Feb 22, 2022
@hugoattal @Akryum
test: Add unit test framework (fix #20) (#40)
7925d92 
Co-authored-by: Guillaume Chau <guillaume.b.chau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hugoattal hugoattal

Labels
enhancement New feature or request ready to be implemented Design is done and implementation can be done in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add unit test framework (fix #20) histoire-dev/histoire
2 participants
@Akryum @hugoattal