Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get background color in stories #328

Closed
4 tasks done
faga295 opened this issue Oct 15, 2022 · 1 comment
Closed
4 tasks done

get background color in stories #328

faga295 opened this issue Oct 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@faga295
Copy link
Contributor

faga295 commented Oct 15, 2022

Clear and concise description of the problem

As a developer using Histoire I wish dynamicly change my text color depending on background color so that get background color in stories is helpful.I intend to submit a PR for this issue.

Suggested solution

maybe we can use project/inject,or some hooks in story component to get the background color,or provide a contrast color variable in global css

Alternative

No response

Additional context

No response

Validations

@faga295 faga295 added the enhancement: to triage New feature of request pending review by team member label Oct 15, 2022
@Akryum
Copy link
Member

Akryum commented Oct 17, 2022

Providing a contrast color (through a CSS variable) alongside a background color for each background preset seems good!

@Akryum Akryum added enhancement New feature or request and removed enhancement: to triage New feature of request pending review by team member labels Oct 17, 2022
@faga295 faga295 closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants