Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEOPLE: Wizard Step MainEmailForm #602

Closed
2 tasks done
daniel-illi opened this issue Jun 7, 2024 · 0 comments · Fixed by #656
Closed
2 tasks done

PEOPLE: Wizard Step MainEmailForm #602

daniel-illi opened this issue Jun 7, 2024 · 0 comments · Fixed by #656

Comments

@daniel-illi
Copy link
Contributor

daniel-illi commented Jun 7, 2024

depends on hitobito/hitobito#2654

Für die verschiedenen onboarding wizards im SAC wagon soll ein WizardStep Wizards::Steps::MainEmailForm implementiert werden.

Vor der Umsetzung bitte mit @daniel-illi besprechen.

Tech-Spec

Ein POC existiert auf dem branch poc/wizard-registration und ein dazugehöriger Draft PR https://github.com/hitobito/hitobito/pull/2653/files?w=1 / https://github.com/hitobito/hitobito_sac_cas/pull/603/files?w=1
Dieser soll als Vorlage für die Implementation verwendet werden.

  • Subklasse von WizardStep, include ValidatedEmail
  • einzelnes Attribut email: attribute :email, :string
  • Validierungen:
    • validates :email, presence: true
    • validieren, dass die Email von keiner anderen Person verwendet wird
    • Gültigkeit der Email wird vom ValidatedEmail geprüft. Dafür braucht es auf dem step die Methode #email_changed?
  • view partial app/views/wizards/steps/_main_email_form.html.haml
    • Eingabefeld für Email Adresse

ToDo

  • Domainklasse erstellen oder anpassen
  • Specs schreiben
@daniel-illi daniel-illi self-assigned this Jun 7, 2024
@daniel-illi daniel-illi changed the title PEOPLE: wizard step MainEmail PEOPLE: Wizard Step MainEmail Jun 7, 2024
@daniel-illi daniel-illi added the blocked Waiting for another issue to be finished before this can be continued label Jun 7, 2024
@daniel-illi daniel-illi removed their assignment Jun 7, 2024
@daniel-illi daniel-illi changed the title PEOPLE: Wizard Step MainEmail PEOPLE: Wizard Step MainEmailForm Jun 13, 2024
@daniel-illi daniel-illi removed the blocked Waiting for another issue to be finished before this can be continued label Jun 17, 2024
@rnestler rnestler self-assigned this Jun 18, 2024
@rnestler rnestler linked a pull request Jun 19, 2024 that will close this issue
@rnestler rnestler removed their assignment Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants