Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MainEmail wizard step #656

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Jun 18, 2024

Refs: #602

image

image

@rnestler rnestler force-pushed the feature/602-addwizard-step-main-email-form branch 2 times, most recently from f3873d6 to 2bf042c Compare June 19, 2024 10:06
@rnestler rnestler marked this pull request as ready for review June 19, 2024 10:07
@rnestler rnestler changed the base branch from master to feature/624-wizards-choose-sektion-form-step June 19, 2024 10:07
Comment on lines 11 to 14
-#.btn-toolbar.bottom.allign-with-form
-# = c.navigation_links

-# = render 'shared_partial'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the POC branch. Will this be done differently?

@rnestler rnestler linked an issue Jun 19, 2024 that may be closed by this pull request
2 tasks
@rnestler rnestler force-pushed the feature/602-addwizard-step-main-email-form branch 3 times, most recently from cef27fa to d9aa620 Compare June 19, 2024 11:44
@amaierhofer amaierhofer force-pushed the feature/624-wizards-choose-sektion-form-step branch from 7d8362e to 7a19775 Compare June 19, 2024 12:02
Base automatically changed from feature/624-wizards-choose-sektion-form-step to master June 19, 2024 12:03
@rnestler rnestler force-pushed the feature/602-addwizard-step-main-email-form branch from d9aa620 to 92cdcc5 Compare June 19, 2024 12:11
context 'with valid email' do
let(:params) { { email: 'foo@bar.ch' } }

it { is_expected.to be_valid }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the it without description are a problem, please tell me how it should be done 🙂

@rnestler rnestler force-pushed the feature/602-addwizard-step-main-email-form branch from 92cdcc5 to 8e0ac40 Compare June 19, 2024 15:12
@rnestler rnestler changed the title Add Wizards::Steps::MainEmail model Add MainEmail wizard step Jun 19, 2024
@rnestler rnestler force-pushed the feature/602-addwizard-step-main-email-form branch from 23056a0 to fda01d0 Compare June 21, 2024 09:36
@rnestler rnestler removed the request for review from amaierhofer June 21, 2024 09:44
@amaierhofer
Copy link
Contributor

LGTM, hab noch das API leicht angepasst, damit die error messages zentral gerendert werden.

@amaierhofer amaierhofer merged commit cc8178b into master Jun 21, 2024
5 of 7 checks passed
@amaierhofer amaierhofer deleted the feature/602-addwizard-step-main-email-form branch June 21, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEOPLE: Wizard Step MainEmailForm
2 participants