Add MainEmail wizard step #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
feature/602-addwizard-step-main-email-form
branch
2 times, most recently
from
f3873d6
to
2bf042c
Compare
rnestler
changed the base branch from
master
to
feature/624-wizards-choose-sektion-form-step
rnestler
commented
Jun 19, 2024
Comment on lines
11
to
14
| -#.btn-toolbar.bottom.allign-with-form | ||
| -# = c.navigation_links | ||
|
|
||
| -# = render 'shared_partial' |
There was a problem hiding this comment.
This is from the POC branch. Will this be done differently?
2 tasks
rnestler
force-pushed
the
feature/602-addwizard-step-main-email-form
branch
3 times, most recently
from
cef27fa
to
d9aa620
Compare
amaierhofer
force-pushed
the
feature/624-wizards-choose-sektion-form-step
branch
from
7d8362e
to
7a19775
Compare
Base automatically changed from
feature/624-wizards-choose-sektion-form-step
to
master
June 19, 2024 12:03
rnestler
force-pushed
the
feature/602-addwizard-step-main-email-form
branch
from
d9aa620
to
92cdcc5
Compare
rnestler
commented
Jun 19, 2024
| context 'with valid email' do | ||
| let(:params) { { email: 'foo@bar.ch' } } | ||
|
|
||
| it { is_expected.to be_valid } |
There was a problem hiding this comment.
If the it without description are a problem, please tell me how it should be done 🙂
rnestler
force-pushed
the
feature/602-addwizard-step-main-email-form
branch
from
92cdcc5
to
8e0ac40
Compare
rnestler
changed the title
rnestler
force-pushed
the
feature/602-addwizard-step-main-email-form
branch
from
23056a0
to
fda01d0
Compare
|
LGTM, hab noch das API leicht angepasst, damit die error messages zentral gerendert werden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #602