Add tick registration mechanism #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bt-cryptomancer
requested changes
Jul 7, 2021
There was a problem hiding this comment.
This looks great, should work well! I like how the registerTick action sets the starting block to be the block after it's registered in; that will make things faster for the next release as we can simply wait until all witnesses have upgraded and then register the new tick for donchate's contract.
Some minor points of polish to look at:
-
contractsConfig can also be used to simplify the big chain of if-else-if for "unknown errors" starting around line 164 of libs/Block.js.
-
The registerTick action returns empty logs if it succeeds. I think it should generate some logging output with the contract, action, and startRefBlock.
-
Please fix the lint errors.
|
Requested changes done. PTAL |
bt-cryptomancer
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register all ticking contracts into "contracts_config" table. Allows for putting more global contract settings in the future. Add "registerTick" method for registering additional ticking actions.