fix(111): Fix color contrast for fields error message #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
The PR fixes the failing tests for
color-contrastin the accessibility pipeline. It concerns the error messages displayed below an imput field in a form. The use of ChakraUIred.500(#E53E3E) as a default red colour for the font failed the contrast thresholdThe PR changes the text colour to
red.600(#C53030) and fixes a fewcolor-contrastaccessibility testsBefore
(Note that the tests were not failing before because they were excluding the
color-contrastrules)After