-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(17700): Improve the UX of the metrics panel in the workspace #204
Conversation
Might it be possible to show the complete metric string since that string is used as a direct address of the metric in other systems, like Prometheus/Grafana? Let's link a copy-to-clipboard icon with the tooltip of the raw metric string. |
a64f351
to
62e084a
Compare
CTA added for every stat panel. Copy the metric in context: {"metricName":"com.hivemq.edge.bridge.simons-bridge-there.forward.publish.count","timestamp":"2023-11-21T13:05:20.520Z","value":622308} |
The copy to the clipboard is an excellent feature. Currently, I assume the following use-case/user journey. The user will check out metrics in the workspace and wants to use them in Grafana / Prometheus. To get it running in Grafana, the user only needs the metricName field content, which means, just the metric. Users will likely put it directly in the Grafana query editor which requires only the metricName, |
- refactor layout and style - format number to locale - format increase to number instead of percentage - add support for closing metric
- apply human-readable labels - filter options to match selected component - disable options already in panel
- refactor sample layout to accommodate extra CTAs - fix translations
- add copied toast
- refactor series renderer for accessibility
f5a1f65
to
ac64cf6
Compare
Change made and description updated |
See https://hivemq.kanbanize.com/ctrl_board/57/cards/17700/details/
The PR improves the rendering of metrics in the property side panel of an entity in the workspace and its creation flow.
The PR also adds a "copy-to-clipboard" CTA on the side of every Stat panel. It will copy the metric name as a string into the clipboard
Out-of-scope
Before
After