-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(18348): Add support for dark mode #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
refactor/18077/charts-design-system
branch
from
December 19, 2023 14:29
082249e
to
8ee21ca
Compare
Base automatically changed from
refactor/18077/charts-design-system
to
feat/18150/workspace-manual-grouping
December 19, 2023 14:30
vanch3d
force-pushed
the
feat/18150/workspace-manual-grouping
branch
2 times, most recently
from
December 20, 2023 09:34
307e083
to
72e68e8
Compare
Base automatically changed from
feat/18150/workspace-manual-grouping
to
master
December 20, 2023 10:22
feat(18382): Add tooltip to the relevant icon buttons
refactor(18350): Refactor the theme structure
fix(18349): fix the list and listitem roles
simon622
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and functions as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/18348/details/
This PR is part of an initiative aiming at preparing the styling of
Edge
with the design system being investigated for HiveMQ products.It activates support for the dark mode and makes every component in the app to be both supportive of the dark mode (e.g. remove hard-coded colours) but also better designed for theming (e.g. using either
colorScheme
orvariant
).The refactoring process in this PR tries to ensure that all components from this point forward will be easily styled by a single source of truth, the custom
ChakraUI
theme.The dark mode is also a very welcome addition to accessibility for
Edge
A few related issues are also being fixed:
Edge
node in theWorkspace
has a new designOut-of-scope
Before
After