Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata defaults #515

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Metadata defaults #515

merged 7 commits into from
Aug 23, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented May 20, 2024

This PR will

  • Set defaults to more closely match current prod, there are some deviations still but these are deliberate e.g. in the table. But let's review this with Jeff and Rachel and see if they want anything updated.
  • Adds a new "value" into the PlotSetting this is where we want to a set a default value which is not the first from the dropdown. In particular useful in the bubble plot where having the colour and the size indicators set to the same thing isn't very useful.
  • Hides the "detail" whenever "area" is a single-select. With both filters shown, it made these quite hard to use. If you changed a single select area, you would have to update the detail level to be lower than or equal to the area you had selected, which was a bit clumsy. Feels like a simpler UI to just select the area if it is a single select

@r-ash r-ash changed the base branch from master to table-metadata May 20, 2024 09:26
@r-ash r-ash changed the base branch from table-metadata to tmp-epic-plot-cleanup-input May 20, 2024 16:08
@r-ash r-ash merged commit dc04502 into tmp-epic-plot-cleanup-input Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant