Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

--namespace and --exclude-namespaces seems to be mutually excluded options #123

Open
propalparolnapervom opened this issue Jul 16, 2020 · 2 comments

Comments

@propalparolnapervom
Copy link
Contributor

It happened my very first steps with kube-downscaler were on the Dev env, which is shared with many other people. So I tried to be as careful as it possible and tried to stay within my test Namespace.

Following parameters have been used simultaneously at that time:

  • --namespace - to explicitly include necessary Namespace;
  • --exclude-namespaces - to implicitly include necessary Namespace (by excluding all other Namespaces).

Didn't find any other information in documentation, so I was hoping it could help to double check that only necessary Namespace is affected. But no downscaling was done, until I started to use only one of those parameters.

I'm not good enough in coding to find any confirmation, but it seems that those parameters are mutually excluded. If you can confirm it, I could create a PR to add appropriate notes to the documentation. I believe it might save some time for some users.

P.S. Pretty useful tool is here. Love it.

@hjacobs
Copy link
Owner

hjacobs commented Jul 16, 2020

@propalparolnapervom thanks for the feedback, this is also related to #119.

@propalparolnapervom
Copy link
Contributor Author

appropriate documentation suggestion was made in PR #124

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants