This repository has been archived by the owner on Oct 3, 2020. It is now read-only.
Move Helm chart to "unsupported" #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't use Helm myself and users tend to have troubles with the contributed Helm charts in this repo.
As a first step, move the contributed Helm chart to the
unsupportedfolder to signal that it is not officially supported.I will potentially still accept PRs with fixes for the Helm chart, but I won't review them in detail and there is no guarantee that the Helm chart will work.
See also: https://twitter.com/try_except_/status/1250548088542019586
This is similar to hjacobs/kube-janitor#73 and hjacobs/kube-resource-report#155