Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move feature-flags from CI to nightly #1607

Merged
merged 1 commit into from
May 9, 2022

Conversation

hjdivad
Copy link
Collaborator

@hjdivad hjdivad commented May 9, 2022

We depend on the Ember Data CUSTOM_MODEL_CLASS feature flag, which is
off by default in 3.24.0, and on by default in 3.28.0. We used to have
to test this feature flag against canaries prior to 3.28.0's release,
but no longer.

We no longer depend on any optional feature flags, but still run the job
to ensure that enabling optional features in Ember Data does not
otherwise break ember-m3.

The job will be red right now because we currently are not compatible
with 4.0.0 and also not with canary releases of ember and ember-data.

Co-Authored-By: Larry Yu laryu@linkedin.com

We depend on the Ember Data CUSTOM_MODEL_CLASS feature flag, which is
off by default in 3.24.0, and on by default in 3.28.0. We used to have
to test this feature flag against canaries prior to 3.28.0's release,
but no longer.

We no longer depend on any optional feature flags, but still run the job
to ensure that enabling optional features in Ember Data does not
otherwise break ember-m3.

The job will be red right now because we currently are not compatible
with 4.0.0 and also not with canary releases of ember and ember-data.

Co-Authored-By: Larry Yu <laryu@linkedin.com>
@hjdivad hjdivad requested review from larry-x-yu and rwjblue May 9, 2022 20:57
@github-actions
Copy link

github-actions bot commented May 9, 2022

Performance Report for a0fee8d

Scenario - materializing-lots: ☑️ Performance is stable

☑️ duration
phase no difference [-51ms to 46ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-7ms to 5ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-51ms to 17ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-13ms to 49ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [0ms to 2ms]

Scenario - materializing-small: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 10ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-4ms to 6ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-2ms to 2ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-1ms to 3ms]
⚠️ Phase [end-loading] => [Test End]
phase estimated regression +1ms [0ms to 2ms] OR +2.42% [0.22% to 4.54%]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 7ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-8ms to 2ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-3ms to 1ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-1ms to 0ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-15ms to 9ms]

Copy link
Collaborator

@larry-x-yu larry-x-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjdivad hjdivad merged commit 7db74fb into master May 9, 2022
@hjdivad hjdivad deleted the hjdivad/move-feature-flags-job branch May 9, 2022 23:50
@hjdivad hjdivad added the internal ch:internal label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ch:internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants