-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract file list calculation into seperate, testable class.
- Loading branch information
James Hart
committed
Nov 7, 2015
1 parent
6608bd8
commit 93344d7
Showing
9 changed files
with
93 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
require 'rake/file_list' | ||
|
||
# Grabbed from ActiveSupport | ||
# activesupport/lib/active_support/core_ext/array/grouping.rb, line 60 | ||
class Array | ||
def in_groups(number, fill_with = nil) | ||
# size.div number gives minor group size; | ||
# size % number gives how many objects need extra accommodation; | ||
# each group hold either division or division + 1 items. | ||
division = size.div number | ||
modulo = size % number | ||
|
||
# create a new array avoiding dup | ||
groups = [] | ||
start = 0 | ||
|
||
number.times do |index| | ||
length = division + (modulo > 0 && modulo > index ? 1 : 0) | ||
groups << last_group = slice(start, length) | ||
last_group << fill_with if fill_with != false && | ||
modulo > 0 && length == division | ||
start += length | ||
end | ||
|
||
if block_given? | ||
groups.each { |g| yield(g) } | ||
else | ||
groups | ||
end | ||
end | ||
end | ||
|
||
module Rspec | ||
module Parts | ||
class FileList | ||
def self.from(glob: glob, groups: groups, part: part) | ||
total_file_list = Rake::FileList.new | ||
|
||
Dir.glob(glob).each do |spec_directory| | ||
directory_file_list = Rake::FileList.new | ||
directory_file_list.add("#{spec_directory}/**/*_spec.rb") | ||
subset_of_directory_file_list = directory_file_list.to_a.in_groups(groups, false).at(part) | ||
total_file_list.add(subset_of_directory_file_list) | ||
end | ||
|
||
total_file_list | ||
end | ||
end | ||
end | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Empty file.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
require 'spec_helper' | ||
|
||
describe Rspec::Parts::FileList do | ||
describe '.from' do | ||
let(:subject) { described_class.from(glob: directory_glob, groups: 2, part: part) } | ||
|
||
context 'given a directory with two files in two directories' do | ||
let(:directory_glob) { 'spec/*' } | ||
|
||
context 'part one' do | ||
let(:part) { 0 } | ||
it 'splits the controllers and models directory appropriately' do | ||
filelist = subject.to_a | ||
aggregate_failures do | ||
expect(filelist).to include('spec/controllers/a_spec.rb') | ||
expect(filelist).to include('spec/models/a_spec.rb') | ||
expect(filelist).to include('spec/rspec/parts/file_list_spec.rb') | ||
expect(filelist).to include('spec/rspec/parts/configuration_spec.rb') | ||
end | ||
end | ||
end | ||
|
||
context 'part two' do | ||
let(:part) { 1 } | ||
it 'splits the controllers and models directory appropriately' do | ||
filelist = subject.to_a | ||
aggregate_failures do | ||
expect(filelist).to include('spec/controllers/b_spec.rb') | ||
expect(filelist).to include('spec/models/b_spec.rb') | ||
expect(filelist).to include('spec/rspec/parts_spec.rb') | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end |