Node Connection Updates #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the NatNet actor when no interfaces exist.
More importantly: removed the restriction from ImNodes (slightly hacky, but I couldn't find any external way to do it) that types can only be connected to the same (or "opposite") types. Since the sphactor back-end doesn't care either way, this makes it more flexible. Upshot: record actor now uses "Any" slot type, and doesn't only accept OSC.
It also introduces the ability to create connections that would not work, so we'd need to think about supporting "error handling", or ignoring messages that are not usable by an actor.