Add Penna MDC Adapter #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this local MDC adapter should allow for future optimizaitons
It is expensive in terms of memory to allocate a new map just to hold the contents of data in the map. Given the MDC adapter stores data in a tree-like data structure, we would need two operations: 1) traverse back to the root node and populate the context map, extending it at every node down until the leaf; 2) create an EntrySet to iterate over the items; This implementation drops the need for an intermediary map and abstracts away the tree structure.
This makes the MDC implementation considerably faster when under heavy usage as it avoids the creation of an extra context map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a native MDC adapter to Penna, which should allow for cheaper and faster MDC usage.