Performance improvements #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java seems to have to re-evaluate that reference at every iteration, causing a lambda creation/instantiation. This is solved by storing it in a variable
Instead of using an array for lookup, we let the compiler do the right thing
Evaluating the strings is more expensive and unnecessary for values that we have some confidence won't change or are withing reasonable boundaries
Two important changes: - resizing will occur at 80% mark, but capacity is not re-evaluated every time; - checking sizes have been lifted to higher layers Also, more raw ways of writing values have been exposed. Finally, this uses the new int -> ascii code that is faster because it doesn't need to use a slow log10 computation.
This should allow us to override the previously called `PennaSink`. Also, we remvoe the `OutputManager` and opt for a better solution
There's no difference in performance and we make the code unnecessarily coupled.
Target for jdk 21 should be around 1.0
They're unnecessary, only serve for manual tests. JMH & unit tests should cover performance & functionality. Other kinds of 'acceptance' test should not be done manually as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.