Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH Core Address: Include eCH-0007 cantonAbbreviation – Kantonskürzel (Michaela Ziegler, ahdis) #233

Closed
ig-feedback opened this issue Jun 30, 2023 · 6 comments · Fixed by #234
Assignees
Labels
feature request ready for telco STU 4 Ballot Comments/Issues from the Ballot 2023
Milestone

Comments

@ig-feedback
Copy link
Collaborator

ig-feedback commented Jun 30, 2023

ch.fhir.ig.ch-core#4.0.0-ballot /StructureDefinition-ch-core-address.html

Include "Kantonskürzel" (eCH-0007 specification) to CHCoreAddress: Address.state.

@ziegm ziegm added STU 4 Ballot Comments/Issues from the Ballot 2023 feature request labels Jul 4, 2023
@oliveregger
Copy link
Contributor

Adrian Hager: Da ich gerade daran bin Meldepflichtige Krankheiten an's BAG zu senden und ich mir selbst solch ne Liste zusammenstellen musste fiel mir auf, dass Ihr da FL also Fürstentum Liechtenstein gar nicht mit drauf habt. Keine Ahnung ob das bewusst so gewählt wurde. Ich selbst kann nur sagen, dass wir aber auch Meldungen an Kantonsärzte senden müssen und FL ist da mit dabei.

Auch in dem Referenzierten Dokument hier ist es mit dabei.

@ziegm ziegm self-assigned this Aug 10, 2023
@ziegm ziegm added this to the v4.0.0 milestone Aug 10, 2023
@ziegm
Copy link
Collaborator

ziegm commented Aug 10, 2023

ziegm added a commit that referenced this issue Aug 10, 2023
@ziegm ziegm linked a pull request Aug 10, 2023 that will close this issue
@ziegm
Copy link
Collaborator

ziegm commented Aug 30, 2023

30.08.2023:

  • @EmmanuelEschmann: Profiling element datatype: string -> code (more restrictive, not changing the data type)
  • Procedere: we will check. if it would be possible, we would go in another discussion round, if not, than we can continue with this proposal: 12-0-0

@qligier
Copy link
Member

qligier commented Aug 30, 2023

We can't make it a code only if the country is Switzerland. So it should either be a code all the time, or let it as a string, but that's not the same question and may deserve its own issue.

On a side note, what does eCH says about Liechtenstein addresses? We use ECH007CantonFLAbbreviation when the country code is CH, is Vaduz, FL, CH-9490 accepted/preferred? Because there also is Vaduz, FL, LI-9490, which conforms better to the concept of ISO-3166 country codes.
I.e. Do we have a good reason to use the value set with FL here?

Edit: the constraint does not use ECH007CantonFLAbbreviation but ECH007CantonAbbreviation. The description text is inconsistent: Use values from eCH-0007 Canton Abbreviation (incl. FL) for a Swiss address

ziegm added a commit that referenced this issue Aug 30, 2023
@ziegm
Copy link
Collaborator

ziegm commented Aug 31, 2023

  • https://www.hl7.org/fhir/R4/profiling.html#using
    • Restricting the types for an element that allows multiple types
    • only possilble for value[x]
  • Asked on zulip
    • Changing the datatype isn't possible
    • A binding could be added to the string
      • I would suggest to go on with the proposed rule and an 'example' binding, because the value set contains only Swiss values

@EmmanuelEschmann okay for you?

@ziegm ziegm closed this as completed in #234 Sep 5, 2023
@ziegm ziegm reopened this Sep 5, 2023
@EmmanuelEschmann
Copy link

Thank you for the investigations.
Yes, it's oK for me.

@ziegm ziegm closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ready for telco STU 4 Ballot Comments/Issues from the Ballot 2023
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants