Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs #98

Closed
miakobchuk opened this issue May 8, 2024 · 4 comments
Closed

Breadcrumbs #98

miakobchuk opened this issue May 8, 2024 · 4 comments
Assignees

Comments

@mikeweis
Copy link
Collaborator

Note that using the Block Party implementation of Breadcrumbs requires integration with 24PetWatch's current implementation of the following:

@mikeweis mikeweis self-assigned this Jun 19, 2024
@mikeweis
Copy link
Collaborator

mikeweis commented Jun 20, 2024

Things to note:

  • the Block Party implementation has code that does more than just the breadcrumbs. So we will need to "stitch" the breadcrumb parts (both .js and .css) into the respective Pet Watch customized files.
  • the Block Party implementation uses the existing navigation (<nav>) information that is present in the HTML to flesh out the crumbs. If our .../drafts/develop/* Word documents use an incomplete/fake header, the breadcrumbs can easily reduce to looking like: Home > Title of Current Page (instead of Home > Title of Grandparent Page > Title of Parent Page > Title of Current Page) ... just FYI.
  • your Word document must enable the Breadcrumbs metadata:
-------------------
Metadata
-------------------
Breadcrumbs | true
-------------------

mikeweis pushed a commit that referenced this issue Jun 20, 2024
@mikeweis
Copy link
Collaborator

PR: #130

mikeweis added a commit that referenced this issue Jun 20, 2024
Co-authored-by: Mike Weis <miweis@magento.com>
@mikeweis
Copy link
Collaborator

Done.

  • code merged: CSS + JS
  • applicable documents updated & available on Sharepoint: US + CA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants