generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alloy and related scripts #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Co-authored-by: Vitaly Tsaplin <vitaly@tsaplin.com> Co-authored-by: vradulescu-bd <140399829+vradulescu-bd@users.noreply.github.com> Co-authored-by: Tobi Reiss <reiss@adobe.com> Co-authored-by: Andrei Bogdan <166901+andreibogdan@users.noreply.github.com> Co-authored-by: Andrei Bogdan <andbogda@adobe.com> Co-authored-by: ext-vradulescu <ext-vradulescu@bitdefender.com> Co-authored-by: Julien Ramboz <ramboz@adobe.com> Co-authored-by: Vitaly Tsaplin <tsaplin@adobe.com>
Co-authored-by: Vitaly Tsaplin <vitaly@tsaplin.com> Co-authored-by: vradulescu-bd <140399829+vradulescu-bd@users.noreply.github.com> Co-authored-by: Tobi Reiss <reiss@adobe.com> Co-authored-by: Andrei Bogdan <166901+andreibogdan@users.noreply.github.com> Co-authored-by: Andrei Bogdan <andbogda@adobe.com> Co-authored-by: ext-vradulescu <ext-vradulescu@bitdefender.com> Co-authored-by: Julien Ramboz <ramboz@adobe.com> Co-authored-by: Vitaly Tsaplin <tsaplin@adobe.com>
# Conflicts: # .eslintignore # solutions/blocks/footer/footer.js # solutions/blocks/header/header.js # solutions/scripts/delayed.js # solutions/scripts/scripts.js
cuzuco2
reviewed
Apr 10, 2024
cuzuco2
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on my side
nsdere
pushed a commit
that referenced
this pull request
Apr 16, 2024
vtsaplin
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #397
Test URLs:
For the reviewers:
Just look at
analytics.js
,onetrust.js
andscripts.js