Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alloy and related scripts #433

Merged
merged 16 commits into from
Apr 16, 2024
Merged

feat: add alloy and related scripts #433

merged 16 commits into from
Apr 16, 2024

Conversation

vtsaplin
Copy link
Collaborator

@vtsaplin vtsaplin commented Jan 10, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #397

Test URLs:

For the reviewers:

Just look at analytics.js, onetrust.js and scripts.js

Copy link

aem-code-sync bot commented Jan 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 10, 2024

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Co-authored-by: Vitaly Tsaplin <vitaly@tsaplin.com>
Co-authored-by: vradulescu-bd <140399829+vradulescu-bd@users.noreply.github.com>
Co-authored-by: Tobi Reiss <reiss@adobe.com>
Co-authored-by: Andrei Bogdan <166901+andreibogdan@users.noreply.github.com>
Co-authored-by: Andrei Bogdan <andbogda@adobe.com>
Co-authored-by: ext-vradulescu <ext-vradulescu@bitdefender.com>
Co-authored-by: Julien Ramboz <ramboz@adobe.com>
Co-authored-by: Vitaly Tsaplin <tsaplin@adobe.com>
Co-authored-by: Vitaly Tsaplin <vitaly@tsaplin.com>
Co-authored-by: vradulescu-bd <140399829+vradulescu-bd@users.noreply.github.com>
Co-authored-by: Tobi Reiss <reiss@adobe.com>
Co-authored-by: Andrei Bogdan <166901+andreibogdan@users.noreply.github.com>
Co-authored-by: Andrei Bogdan <andbogda@adobe.com>
Co-authored-by: ext-vradulescu <ext-vradulescu@bitdefender.com>
Co-authored-by: Julien Ramboz <ramboz@adobe.com>
Co-authored-by: Vitaly Tsaplin <tsaplin@adobe.com>
# Conflicts:
#	.eslintignore
#	solutions/blocks/footer/footer.js
#	solutions/blocks/header/header.js
#	solutions/scripts/delayed.js
#	solutions/scripts/scripts.js
solutions/scripts/onetrust.js Show resolved Hide resolved
solutions/scripts/onetrust.js Outdated Show resolved Hide resolved
solutions/scripts/onetrust.js Outdated Show resolved Hide resolved
@vtsaplin vtsaplin requested a review from cuzuco2 April 12, 2024 16:51
Copy link

@cuzuco2 cuzuco2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my side

@vtsaplin vtsaplin merged commit 04ab2f0 into main Apr 16, 2024
2 of 3 checks passed
@vtsaplin vtsaplin deleted the websdk branch April 16, 2024 12:30
nsdere pushed a commit that referenced this pull request Apr 16, 2024
vtsaplin added a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up WebSDK
2 participants