Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate target using json offers #474

Merged
merged 34 commits into from
May 30, 2024
Merged

feat: integrate target using json offers #474

merged 34 commits into from
May 30, 2024

Conversation

vtsaplin
Copy link
Collaborator

@vtsaplin vtsaplin commented Apr 22, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #450

Test URLs:

Copy link

aem-code-sync bot commented Apr 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 24, 2024

Page Scores Audits Google
/solutions/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic looks good. I left various comments for minor things.

solutions/scripts/target.js Outdated Show resolved Hide resolved
solutions/scripts/scripts.js Outdated Show resolved Hide resolved
solutions/scripts/scripts.js Outdated Show resolved Hide resolved
solutions/scripts/scripts.js Show resolved Hide resolved
solutions/scripts/target.js Show resolved Hide resolved
solutions/scripts/target.js Show resolved Hide resolved
solutions/scripts/target.js Show resolved Hide resolved
solutions/scripts/target.js Outdated Show resolved Hide resolved
solutions/scripts/target.js Show resolved Hide resolved
@vtsaplin vtsaplin merged commit 9293800 into main May 30, 2024
2 of 3 checks passed
@vtsaplin vtsaplin deleted the target-json branch May 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Target integration using JSON offers
3 participants