Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom section ids #455

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: custom section ids #455

merged 1 commit into from
Mar 7, 2024

Conversation

iansk
Copy link
Collaborator

@iansk iansk commented Feb 27, 2024

Fix issue with custom section ids being rendered as para text instead of being properly applied as the secion/div id.

Fix hlxsites/prisma-cloud-docs-website#205

Copy link
Contributor

aem-code-sync bot commented Feb 27, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

@maxakuru maxakuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message on slack, but for future reference:

I think what we want to do is make the section metadata application more conservative instead of changing it’s placement

https://github.com/hlxsites/prisma-cloud-docs/blob/main/worker/src/util/adoc2html.ts#L187
should possibly be const sectionMeta = !id.startsWith('_') && this.sectionDepth === 1

needs testing, though

@iansk
Copy link
Collaborator Author

iansk commented Feb 29, 2024

Thanks @maxakuru, I just sent you a message on Slack with my analysis. I think this is structured correctly, but I could be missing something.

@maxakuru maxakuru self-requested a review March 4, 2024 21:05
Copy link
Contributor

@maxakuru maxakuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we discussed offline I'm probably wrong about the issue mentioned, but would recommend merging and testing on a few complex adocs before publishing too many pages

@iansk iansk merged commit 3e2dce1 into main Mar 7, 2024
3 of 4 checks passed
@iansk iansk deleted the ian/fix-custom-ids branch March 7, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AsciiDoc conversion] Stray id text 2
2 participants