Merge pull request #30 from hlysine/develop

hlysine · Jun 11, 2023 · c280d16 · c280d16
2 parents d434b4b + c339023
commit c280d16
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/__tests__/helper.test.tsx b/src/__tests__/helper.test.tsx
@@ -25,6 +25,13 @@ describe('createWrappedRef', () => {
     expect(Object.getOwnPropertyDescriptor(wrapped, 'a')).toEqual(
       Object.getOwnPropertyDescriptor(obj, 'a')
     );
+
+    Object.defineProperty(obj, 'a', {
+      configurable: false,
+    });
+    // expect non-configurable properties to not be reported as existing
+    // see invariants at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/getOwnPropertyDescriptor#invariants
+    expect(Object.getOwnPropertyDescriptor(wrapped, 'a')).toBeUndefined();
   });
   it('traps getPrototypeOf', () => {
     const obj = { a: 1 };

diff --git a/src/helper.ts b/src/helper.ts
@@ -109,7 +109,14 @@ export function createWrappedRef<T>(ref: T): WrappedRef<T> {
       else return Reflect.get(target[WRAP_KEY] as any, p, receiver);
     },
     getOwnPropertyDescriptor(target, p) {
-      return Reflect.getOwnPropertyDescriptor(target[WRAP_KEY] as any, p);
+      const descriptor = Reflect.getOwnPropertyDescriptor(
+        target[WRAP_KEY] as any,
+        p
+      );
+      if (descriptor && !descriptor.configurable) {
+        return undefined;
+      }
+      return descriptor;
     },
     getPrototypeOf(target) {
       return Reflect.getPrototypeOf(target[WRAP_KEY] as any);