Mark instance matrix as dirty when controlled particle unmounts.

hmans · Sep 26, 2022 · 8376e3e · 8376e3e
1 parent 4785f05
commit 8376e3e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/thirty-owls-sin.md b/.changeset/thirty-owls-sin.md
@@ -0,0 +1,5 @@
+---
+"vfx-composer-r3f": patch
+---
+
+When a controlled particles is unmounted, it will now automatically mark the particle system's instance matrix for reupload.
diff --git a/packages/vfx-composer-r3f/src/Particle.tsx b/packages/vfx-composer-r3f/src/Particle.tsx
@@ -1,4 +1,4 @@
-import { Object3DProps, useFrame } from "@react-three/fiber"
+import { Object3DProps } from "@react-three/fiber"
 import React, {
   forwardRef,
   useImperativeHandle,
@@ -41,6 +41,7 @@ export const Particle = forwardRef<Object3D, Object3DProps>((props, ref) => {
     return () => {
       ecs.destroyEntity(entity)
       particles.setMatrixAt(cursor, hideMatrix)
+      particles.instanceMatrix.needsUpdate = true
     }
   }, [particles])
 

diff --git a/packages/vfx-composer-r3f/src/Particles.tsx b/packages/vfx-composer-r3f/src/Particles.tsx
@@ -78,7 +78,7 @@ export const Particles = forwardRef<ParticlesImpl, ParticlesProps>(
     )
 
     useFrame(() => {
-      if (!ecs.entities.length) return
+      if (ecs.entities.length === 0) return
 
       /* Make sure the effect's world matrix is up to date */
       particles.updateMatrixWorld()