When deriving a bucket, set its entities immediately

hmans · Oct 25, 2022 · a1f2d79 · a1f2d79
1 parent f7aeab1
commit a1f2d79
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/packages/miniplex-core/src/Bucket.ts b/packages/miniplex-core/src/Bucket.ts
@@ -193,18 +193,13 @@ export class Bucket<E> {
     if (existingBucket) return existingBucket
 
     /* Create bucket */
-    const bucket = new Bucket<D>()
+    const bucket = new Bucket<D>({
+      entities: this.entities.filter(predicate) as D[]
+    })
 
     /* Add to cache */
     this.derivedBuckets.set(predicate, bucket)
 
-    /* Add entities that match the predicate */
-    for (const entity of this.entities) {
-      if (predicate(entity)) {
-        bucket.add(entity)
-      }
-    }
-
     /* Listen for new entities */
     bucket.onDisposed.add(
       this.onEntityAdded.add((entity) => {