Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CODEOWNERS declare rules with no owners #7

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Allow CODEOWNERS declare rules with no owners #7

merged 1 commit into from
Mar 9, 2022

Conversation

obukhov
Copy link
Contributor

@obukhov obukhov commented Mar 2, 2022

Fixes #4

Hello dear @hmarr
Thanks for the library

I faced the same problem described in #4
My case is that I want to own a folder except one file in it to keep it open for collaboration without enforced review.

Please have a look at suggested fix and let me know what you think

@obukhov
Copy link
Contributor Author

obukhov commented Mar 5, 2022

@hmarr any chance you can have a look?

@hmarr hmarr merged commit 30020e6 into hmarr:main Mar 9, 2022
@hmarr
Copy link
Owner

hmarr commented Mar 9, 2022

Thanks for taking this on, and sorry for the slow review!

@obukhov obukhov deleted the allow-rules-with-no-owners branch March 9, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when codeowners file lists an empty owner
2 participants