PAY-6706: New CFT APIM Migration #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davejones74
changed the title
Plan Result (aat)
Change Result (Click me) # azurerm_api_management_subscription.fee_pay_team_fee_register_subscription will be updated in-place
~ resource "azurerm_api_management_subscription" "fee_pay_team_fee_register_subscription" {
~ allow_tracing = false -> true
id = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-stg/subscriptions/7a413a4b-70fd-43ae-891f-781fb1b54508"
# (10 unchanged attributes hidden)
}
# azurerm_api_management_subscription.liberata_supplier_fee_register_subscription will be updated in-place
~ resource "azurerm_api_management_subscription" "liberata_supplier_fee_register_subscription" {
~ allow_tracing = false -> true
id = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-stg/subscriptions/1b28771a-f1bf-484a-b7f6-ead7cc86407f"
# (10 unchanged attributes hidden)
}
# module.cft_api_mgmt_api.azurerm_api_management_api.api will be updated in-place
~ resource "azurerm_api_management_api" "api" {
id = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-stg/apis/feeregister-api;rev=1"
name = "feeregister-api"
~ protocols = [
+ "http",
# (1 unchanged element hidden)
]
# (17 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.cft_api_mgmt_policy.azurerm_api_management_api_policy.api_policy will be updated in-place
~ resource "azurerm_api_management_api_policy" "api_policy" {
id = "/subscriptions/96c274ce-846d-4e48-89a7-d528432298a7/resourceGroups/cft-aat-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-stg/apis/feeregister-api"
~ xml_content = <<-EOT
- <policies>
- <backend>
- <base />
- </backend>
- <inbound>
- <base />
- <choose>
- <when condition="@(context.Request.Headers["X-ARR-ClientCertThumbprint"] == null)">
- <return-response>
- <set-status code="401" />
- <set-body>Missing client certificate</set-body>
- </return-response>
- </when>
- <when condition="@(!(new string[] {"B1BF8007527F85085D7C4A3DC406A9A6D124D721","E5F54E7BA2B780E2B1B1FFAC68F801251935BE80","B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","D36AC5686200258AE7C03CCCA70E14B69C17F94B"}.Any(c => context.Request.Headers.ContainsKey("X-ARR-ClientCertThumbprint") && context.Request.Headers["X-ARR-ClientCertThumbprint"].Contains(c))))">
- <return-response>
- <set-status code="401" />
- <set-body>Invalid client certificate</set-body>
- </return-response>
- </when>
- <when condition="@(context.Request.Certificate == null || context.Request.Certificate.NotAfter < DateTime.Now || context.Request.Certificate.NotBefore > DateTime.Now || !(new string[] {"B1BF8007527F85085D7C4A3DC406A9A6D124D721","E5F54E7BA2B780E2B1B1FFAC68F801251935BE80","B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","D36AC5686200258AE7C03CCCA70E14B69C17F94B"}.Any(c => c == context.Request.Certificate.Thumbprint)))">
- <return-response>
- <set-status code="401" reason="Invalid client certificate. Please check expiry." />
- </return-response>
- </when>
- </choose>
- </inbound>
- <outbound>
- <base />
- </outbound>
- <on-error>
- <base />
- </on-error>
+ <policies>
+ <backend>
+ <base/>
+ </backend>
+ <inbound>
+ <base/>
+ <choose>
+ <when condition="@(context.Request.Headers["X-ARR-ClientCertThumbprint"] == null)">
+ <return-response>
+ <set-status code="401" />
+ <set-body>Missing client certificate.</set-body>
+ </return-response>
+ </when>
+ <when condition="@(!(new string[] {"B1BF8007527F85085D7C4A3DC406A9A6D124D721","E5F54E7BA2B780E2B1B1FFAC68F801251935BE80","B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","D36AC5686200258AE7C03CCCA70E14B69C17F94B"}.Contains(context.Request.Headers["X-ARR-ClientCertThumbprint"].First().ToUpperInvariant())))">
+ <return-response>
+ <set-status code="401" />
+ <set-body>Invalid client certificate.</set-body>
+ </return-response>
+ </when>
+ <!-- <when condition="@(context.Request.Certificate == null || context.Request.Certificate.NotAfter < DateTime.Now || context.Request.Certificate.NotBefore > DateTime.Now || !(new string[] {"B1BF8007527F85085D7C4A3DC406A9A6D124D721","E5F54E7BA2B780E2B1B1FFAC68F801251935BE80","B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","D36AC5686200258AE7C03CCCA70E14B69C17F94B"}.Any(c => c == context.Request.Certificate.Thumbprint)))" >-->
+ <!-- <return-response>-->
+ <!-- <set-status code="401" />-->
+ <!-- <set-body>Invalid client certificate. Please check expiry.</set-body>-->
+ <!-- </return-response>-->
+ <!-- </when>-->
+ </choose>
+ </inbound>
+ <outbound>
+ <base/>
+ </outbound>
+ <on-error>
+ <base/>
+ </on-error>
</policies>
EOT
# (3 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # azurerm_api_management_subscription.fee_pay_team_fee_register_subscription will be updated in-place
~ resource "azurerm_api_management_subscription" "fee_pay_team_fee_register_subscription" {
~ allow_tracing = false -> true
id = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-prod/subscriptions/e7275ccd-3c77-4a1e-abc1-e7238ca213f3"
# (10 unchanged attributes hidden)
}
# azurerm_api_management_subscription.liberata_supplier_fee_register_subscription will be updated in-place
~ resource "azurerm_api_management_subscription" "liberata_supplier_fee_register_subscription" {
~ allow_tracing = false -> true
id = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-prod/subscriptions/027a013b-1be4-4c13-9888-705b9e0d3982"
# (10 unchanged attributes hidden)
}
# module.cft_api_mgmt_api.azurerm_api_management_api.api will be updated in-place
~ resource "azurerm_api_management_api" "api" {
id = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-prod/apis/feeregister-api;rev=1"
name = "feeregister-api"
~ protocols = [
+ "http",
# (1 unchanged element hidden)
]
# (17 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.cft_api_mgmt_policy.azurerm_api_management_api_policy.api_policy will be updated in-place
~ resource "azurerm_api_management_api_policy" "api_policy" {
id = "/subscriptions/8cbc6f36-7c56-4963-9d36-739db5d00b27/resourceGroups/cft-prod-network-rg/providers/Microsoft.ApiManagement/service/cft-api-mgmt-prod/apis/feeregister-api"
~ xml_content = <<-EOT
- <policies>
- <backend>
- <base />
- </backend>
- <inbound>
- <base />
- <choose>
- <when condition="@(context.Request.Headers["X-ARR-ClientCertThumbprint"] == null)">
- <return-response>
- <set-status code="401" />
- <set-body>Missing client certificate</set-body>
- </return-response>
- </when>
- <when condition="@(!(new string[] {"B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","68EDF481C5394D65962E9810913455D3EC635FA5","B1BF8007527F85085D7C4A3DC406A9A6D124D721","B49BDDE7818B78058AC7401BE0284A40845031E3","C6E2FBAB5FED58FD86C10A3BD212CF44668FD1A3","7744A2F56BD3B73C0D7FED61309E1C65AF08538C"}.Any(c => context.Request.Headers.ContainsKey("X-ARR-ClientCertThumbprint") && context.Request.Headers["X-ARR-ClientCertThumbprint"].Contains(c))))">
- <return-response>
- <set-status code="401" />
- <set-body>Invalid client certificate</set-body>
- </return-response>
- </when>
- <when condition="@(context.Request.Certificate == null || context.Request.Certificate.NotAfter < DateTime.Now || context.Request.Certificate.NotBefore > DateTime.Now || !(new string[] {"B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","68EDF481C5394D65962E9810913455D3EC635FA5","B1BF8007527F85085D7C4A3DC406A9A6D124D721","B49BDDE7818B78058AC7401BE0284A40845031E3","C6E2FBAB5FED58FD86C10A3BD212CF44668FD1A3","7744A2F56BD3B73C0D7FED61309E1C65AF08538C"}.Any(c => c == context.Request.Certificate.Thumbprint)))">
- <return-response>
- <set-status code="401" reason="Invalid client certificate. Please check expiry." />
- </return-response>
- </when>
- </choose>
- </inbound>
- <outbound>
- <base />
- </outbound>
- <on-error>
- <base />
- </on-error>
+ <policies>
+ <backend>
+ <base/>
+ </backend>
+ <inbound>
+ <base/>
+ <choose>
+ <when condition="@(context.Request.Headers["X-ARR-ClientCertThumbprint"] == null)">
+ <return-response>
+ <set-status code="401" />
+ <set-body>Missing client certificate.</set-body>
+ </return-response>
+ </when>
+ <when condition="@(!(new string[] {"B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","68EDF481C5394D65962E9810913455D3EC635FA5","B1BF8007527F85085D7C4A3DC406A9A6D124D721","B49BDDE7818B78058AC7401BE0284A40845031E3","C6E2FBAB5FED58FD86C10A3BD212CF44668FD1A3","7744A2F56BD3B73C0D7FED61309E1C65AF08538C"}.Contains(context.Request.Headers["X-ARR-ClientCertThumbprint"].First().ToUpperInvariant())))">
+ <return-response>
+ <set-status code="401" />
+ <set-body>Invalid client certificate.</set-body>
+ </return-response>
+ </when>
+ <!-- <when condition="@(context.Request.Certificate == null || context.Request.Certificate.NotAfter < DateTime.Now || context.Request.Certificate.NotBefore > DateTime.Now || !(new string[] {"B9D9E70AC23EAF8EA094F6B59EF77FF77D977CBE","68EDF481C5394D65962E9810913455D3EC635FA5","B1BF8007527F85085D7C4A3DC406A9A6D124D721","B49BDDE7818B78058AC7401BE0284A40845031E3","C6E2FBAB5FED58FD86C10A3BD212CF44668FD1A3","7744A2F56BD3B73C0D7FED61309E1C65AF08538C"}.Any(c => c == context.Request.Certificate.Thumbprint)))" >-->
+ <!-- <return-response>-->
+ <!-- <set-status code="401" />-->
+ <!-- <set-body>Invalid client certificate. Please check expiry.</set-body>-->
+ <!-- </return-response>-->
+ <!-- </when>-->
+ </choose>
+ </inbound>
+ <outbound>
+ <base/>
+ </outbound>
+ <on-error>
+ <base/>
+ </on-error>
</policies>
EOT
# (3 unchanged attributes hidden)
}
Plan: 0 to add, 4 to change, 0 to destroy. |
Thor-tech-of-metal
previously approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/PAY-6706
Change description
New APIM API Migration including updated API Policy for app-gateway and exela self certs."
Checklist