Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .flash selector to avoid modernizr conflicts #141

Closed
rpowis opened this issue May 22, 2015 · 3 comments
Closed

Rename .flash selector to avoid modernizr conflicts #141

rpowis opened this issue May 22, 2015 · 3 comments

Comments

@rpowis
Copy link
Contributor

rpowis commented May 22, 2015

Using an auto-generated modernizr build tool, the stylesheets are scraped for class names matching modernizr classes.

.flash is used for detecting Flash so when the page loads we end up targeting both <html> as well as any notifications on the page.

@rpowis rpowis changed the title Rename .flash selector to avoid modernizr conflicts Rename .flash selector to avoid modernizr conflicts May 22, 2015
@rpowis
Copy link
Contributor Author

rpowis commented May 2, 2017

The version we're currently using is here: http://hmrc.github.io/assets-frontend/section-notification.html#kssref-notification-flash

Need to see if GOV.UK have a similar pattern that isn't named .flash before we consider renaming the one mentioned here.

@gavinwye
Copy link
Contributor

gavinwye commented May 2, 2017

Need to use the component finder on this to find services that are using it and then talk to the service team to find out why they are using this over any available GOV.UK banner.

@gordonmcmullan
Copy link
Contributor

gordonmcmullan commented Feb 19, 2018

This is no longer included in v4.x.x releases therefore closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants