Component library documentation form #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manageable, add comp lib comments to files
| <div class="form-group form-group-year"> | ||
| <label for="year" class="block-label"> | ||
| <input class="input--xsmall" type="number" pattern="[0-9]*" min="0" max="31" id="year" name="year"/> | ||
| Blue |
There was a problem hiding this comment.
Could this example have a more relevant name such as "Day" or "Month"?
| Inline | ||
|
|
||
| For an inline elements you have a few choices. | ||
|
|
There was a problem hiding this comment.
needs to be either singular or plural
|
a few comments around the comp lib examples, otherwise LGTM. |
feedmypixel
force-pushed
the
component-library-documentation-form
branch
from
3f0b1c9
to
e8c78b4
Compare
benaveryee
added a commit
that referenced
this pull request
Mar 14, 2016
Component library documentation form
hmrc-web-operations
pushed a commit
that referenced
this pull request
Mar 14, 2016
…ation-form generated from commit f786097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component Library comments _forms.scss
This body of work is to comment the
_forms.scssfile for the component library. It has also involved splitting the file out into sensible files.Form
Form hint
Label
Radio Input
Select input
Text input
Textarea input