New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to a list #31
Comments
This from Register a company |
@jennifer-hodgson I just remembered this DWP version. https://dwp-patterns.herokuapp.com/additemstoalist |
Similar to Edit a list on the GOV.UK Design System backlog. I think it is similar enough to merge. |
Yup - think we should upstream our variant |
We tested this pattern (with a couple of slight changes) with agents last week: Context: agents use the service to build an authorisation request for their client, and they add tax services to the request one at a time before sending it to their client. We needed to include the name of the client and the service they were requesting authorisation for in the table for it to make sense to the user. Regarding CTA's, 'change' is not an option since it's not technically possible to change the request once it's been created, though it can be deleted before the agent sends to the client. Contrary to the screengrab above, the version we tested used the word 'delete' instead of 'remove', though after the testing we changed the wording to the softer sounding 'remove' as we felt it fitted the use case better: "remove a pending request" rather than "delete a pending request". We'll see how this tests in the next few weeks. Overall the pattern worked well. Users understood the page straight away and were happy with what the table was showing, and understood the calls to action. |
Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site. I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github. |
Added to the Edit a list pattern on GOV.UK issues backlog |
Comment seems to be still appearing for now. |
yes good point. We can add links when we have a more permanent home for out design library. |
@ladine-cook Yes, if a limit is reached, the questions "Do you want to add another" is removed (like PODS). Then replaced with an Inset text with content saying they have reached the limit of X and if they need to add more they must remove X or contact HMRC. As well as a green button to continue. In our case, the button will take the user to same as if they said No to the question (back to a task list). |
Having the list rows marked up in the current way (a list item with the items within in spans) can be improved by moving to a definition list pattern (as used elsewhere, for example in the summary list pattern on Gov Frontend). Whilst with a definition list the key ( Suggested markup:
|
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Adam Liptrot found that when interacting with the list using JAWS list items dialog that the subject of each list item AND the labels for the actions available to operate on that subject would be announced all together rather than just the label for the subject. Source of change request: hmrc/design-patterns#31 (comment)
Two changes proposed to this component, decision record has been drafted in hmrc-frontend pull request which has more context and some pros/cons to review before we make a decision. I will arrange a meeting for later this week (calendars permitting) to make a choice after people have had a chance to feed back anything they want:
|
MOJ have published a new pattern called 'Add to a list': Comments and feedback can be made on the GitHub Discussion: |
The navigation of the
|
Hi @nubz an 'Add to list' discussion has been added to the next Design Resources Working Group meet-up agenda (with Adele Rotella). Feel free to join us at 1pm 3/3/23 https://meet.google.com/ept-fkcd-dpu if you can. |
Hello, We have used the 'add to a list' pattern alongside pagination recently on our HMRC project. Here are some of the recent findings from our latest round of user research with 6 users. For context, the user is taken to this page after uploading a file containing member information. There is also the option for the user to enter each member manually.
|
Minor point. We've tested add to a list in a lot of research sessions and users easily understand it. This works when I use the
However, for the second value it seems like I should use <dd class="govuk-summary-list__value govuk-!-font-weight-regular hmrc-summary-list__value"> I don't think this is available in the hmrc CSS though. Suggestions welcome. |
I raised a point on the GOV.UK summary list backlog relating to 3 column widths that may need to be taken into consideration when looking at this comment regarding having key and value in add to list pattern. |
@BoabaFett Thanks for this. As you say, having two elements with the @shabana-ali Is this comment the one you're talking about? We'll keep it in mind with any updates. |
Hi Jeana, If there is no data in a list then there should be not be a list. It should probably be an opening question of ‘do you need to add an XYZ’ (optional) or ‘Add XYZ’ (mandatory) If 3 data items were in a list, and all removed, post submission of final entry, you should be taken to ‘do you need to add XYZ’ (if optional) or ‘no XYZs added, Add XYZ’ if mandatory |
Thanks @a184studio - You're touching on the struggle we're having. If all of the items are removed (with destructive modal notifications), but at least one is required, I think I want to return the user to the first page of the "list" where they add items, and add an alert saying at least one is required. OR I could leave them on the same page where the list was previously add an alert saying "no xyz's were added. Add XYZ", and then the continue button leads them to the first page of the list data collection. I can see pros and cons of both. |
Hi @jeana-adhoc For me if it’s mandatory to add at least one item to a list then it’s a mandatory action. That has optional additions and there for can only becomes a ‘list’ if more than one item is entered. For example. Q1 > Q2 > Q3: Add ‘mandatory item’ > Q4: Do you need to add anymore items Y/N — N > Q5 — Y Q4a: Add Item2 > List page (Mini checkYourAnswers) if you remove Item2 one remains. “You are about to remove the last item, the service needs at least one item to continue” I would say, investigate the CardPatten with AddChange and remove cards from a Mini CYA page I’m out of the country at the minute but happy to talk more when I return. |
Screenshot
The text was updated successfully, but these errors were encountered: