Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to a list #31

Open
rpowis opened this issue Jan 31, 2017 · 40 comments
Open

Add to a list #31

rpowis opened this issue Jan 31, 2017 · 40 comments

Comments

@rpowis
Copy link
Contributor

rpowis commented Jan 31, 2017

Screenshot

image

@gavinwye gavinwye assigned gavinwye and adamliptrot-oc and unassigned gavinwye Sep 6, 2017
@gavinwye gavinwye moved this from Backlog to In progress in HMRC Design Patterns backlog Sep 6, 2017
@stevenaproctor
Copy link

@gavinwye This looks like a combination of #25, #23 and #35 but the hint text is in the wrong place and the month looks like it should be written in full.

@gavinwye gavinwye moved this from In progress to Ready in HMRC Design Patterns backlog Oct 18, 2017
@gavinwye gavinwye moved this from Ready to Backlog in HMRC Design Patterns backlog Nov 8, 2017
@stevenaproctor stevenaproctor changed the title Add another Add to a list Mar 7, 2018
@jennifer-hodgson
Copy link
Contributor

This from CATO
cato

@jennifer-hodgson
Copy link
Contributor

@gordonmcmullan
Copy link
Contributor

gordonmcmullan commented Mar 13, 2018

Discussion Summary from the hackday

img_20180316_150216

img_20180312_133137

@jennifer-hodgson jennifer-hodgson self-assigned this Mar 16, 2018
@adamliptrot-oc
Copy link

image
Here an initial screen indicates the user is about to interact with an add-to-a-list pattern. They then add the first item. A small check-your-answers is displayed to confirm the data collected from adding the item before returning the user to the list (now populated with the item along with change and remove options) and asking the user if they want to add more or continue with the rest of the journey

@stevenaproctor
Copy link

@jennifer-hodgson I just remembered this DWP version. https://dwp-patterns.herokuapp.com/additemstoalist

@jennifer-hodgson jennifer-hodgson moved this from Backlog to Review in HMRC Design Patterns backlog May 10, 2018
@gordonmcmullan gordonmcmullan moved this from Review to Published in HMRC Design Patterns backlog Jun 14, 2018
@stevenaproctor
Copy link

Similar to Edit a list on the GOV.UK Design System backlog. I think it is similar enough to merge.

@jennifer-hodgson
Copy link
Contributor

jennifer-hodgson commented Oct 10, 2018

Yup - think we should upstream our variant

@jdworks
Copy link

jdworks commented Oct 26, 2018

We tested this pattern (with a couple of slight changes) with agents last week:

screenshot 2018-10-26 at 13 34 58

Context: agents use the service to build an authorisation request for their client, and they add tax services to the request one at a time before sending it to their client.

We needed to include the name of the client and the service they were requesting authorisation for in the table for it to make sense to the user. Regarding CTA's, 'change' is not an option since it's not technically possible to change the request once it's been created, though it can be deleted before the agent sends to the client. Contrary to the screengrab above, the version we tested used the word 'delete' instead of 'remove', though after the testing we changed the wording to the softer sounding 'remove' as we felt it fitted the use case better: "remove a pending request" rather than "delete a pending request". We'll see how this tests in the next few weeks.

Overall the pattern worked well. Users understood the page straight away and were happy with what the table was showing, and understood the calls to action.

@jennifer-hodgson
Copy link
Contributor

jennifer-hodgson commented Nov 27, 2018

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.

I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

@mikeash82
Copy link

Added to the Edit a list pattern on GOV.UK issues backlog

@jennifer-hodgson
Copy link
Contributor

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.

I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

Comment seems to be still appearing for now.
My concern is that it's confusing for users and spreads things across two design systems. I know it's an interim solution before we publish publicly but I think we should avoid.

@mikeash82
Copy link

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.
I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

Comment seems to be still appearing for now.
My concern is that it's confusing for users and spreads things across two design systems. I know it's an interim solution before we publish publicly but I think we should avoid.

yes good point. We can add links when we have a more permanent home for out design library.

@R-Derby
Copy link

R-Derby commented Apr 22, 2020

@ladine-cook Yes, if a limit is reached, the questions "Do you want to add another" is removed (like PODS). Then replaced with an Inset text with content saying they have reached the limit of X and if they need to add more they must remove X or contact HMRC. As well as a green button to continue. In our case, the button will take the user to same as if they said No to the question (back to a task list).

image

@adamliptrot-oc
Copy link

Having the list rows marked up in the current way (a list item with the items within in spans) can be improved by moving to a definition list pattern (as used elsewhere, for example in the summary list pattern on Gov Frontend).
This would in particular help JAWS users who utilise the list items dialog. With the current markup the list item is displayed as one thing.

Screenshot 2021-03-11 at 11 07 04

Whilst with a definition list the key (dt) is used as the dialog reference making the list easier to navigate. Semantics-wise it is a somewhat clearer indicator of the relationships in each row.

Screenshot 2021-03-15 at 17 56 48

Suggested markup:

<dl class="hmrc-add-to-a-list hmrc-add-to-a-list--short">
    <div class="hmrc-add-to-a-list__contents">
      <dt class="hmrc-add-to-a-list__identifier hmrc-add-to-a-list__identifier--light">
        Sydney Russell
      </dt>
      <dd class="hmrc-add-to-a-list__change">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Change</span>
          <span class="govuk-visually-hidden">Change Sydney Russell</span>
        </a>
      </dd>
      <dd class="hmrc-add-to-a-list__remove">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Remove</span>
          <span class="govuk-visually-hidden">Remove Sydney Russell from the list</span>
        </a>
      </dd>
    </div>
    <div class="hmrc-add-to-a-list__contents">
      <dt class="hmrc-add-to-a-list__identifier hmrc-add-to-a-list__identifier--light">
        Michael Cain
      </dt>
      <dd class="hmrc-add-to-a-list__change">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Change</span>
          <span class="govuk-visually-hidden">Change Michael Cain</span>
        </a>
      </dd>
      <dd class="hmrc-add-to-a-list__remove">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Remove</span>
          <span class="govuk-visually-hidden">Remove Michael Cain from the list</span>
        </a>
      </dd>
    </div>
    <div class="hmrc-add-to-a-list__contents">
      <dt class="hmrc-add-to-a-list__identifier hmrc-add-to-a-list__identifier--light">
        Jeremy Winter
      </dt>
      <dd class="hmrc-add-to-a-list__change">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Change</span>
          <span class="govuk-visually-hidden">Change Jeremy Winter</span>
        </a>
      </dd>
      <dd class="hmrc-add-to-a-list__remove">
        <a class="govuk-link" href="#">
          <span aria-hidden="true">Remove</span>
          <span class="govuk-visually-hidden">Remove Jeremy Winter from the list</span>
        </a>
      </dd>
    </div>
  </dl>

oscarduignan added a commit to hmrc/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to hmrc/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to oscarduignan/hmrc-frontend that referenced this issue Apr 27, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
oscarduignan added a commit to hmrc/hmrc-frontend that referenced this issue Apr 28, 2021
Adam Liptrot found that when interacting with the list using JAWS list
items dialog that the subject of each list item AND the labels for the
actions available to operate on that subject would be announced
all together rather than just the label for the subject.

Source of change request:
hmrc/design-patterns#31 (comment)
@oscarduignan
Copy link

oscarduignan commented Jun 22, 2021

Two changes proposed to this component, decision record has been drafted in hmrc-frontend pull request which has more context and some pros/cons to review before we make a decision. I will arrange a meeting for later this week (calendars permitting) to make a choice after people have had a chance to feed back anything they want:

@kelliedesigner
Copy link

MOJ have published a new pattern called 'Add to a list':
https://design-patterns.service.justice.gov.uk/patterns/add-to-a-list/

Comments and feedback can be made on the GitHub Discussion:
ministryofjustice/moj-frontend#203

@nubz
Copy link

nubz commented Jan 30, 2023

The navigation of the Add to a list pattern is not immediately obvious in a couple of use cases:

  1. When a user removes the last item from an optional list what screen should be shown on submission of the final removal confirmation?
  2. When a user removes any item from the list what screen should be shown when selecting the back link in the list view?

@Jon-Rowe-HMRC
Copy link

Hi @nubz an 'Add to list' discussion has been added to the next Design Resources Working Group meet-up agenda (with Adele Rotella).

Feel free to join us at 1pm 3/3/23 https://meet.google.com/ept-fkcd-dpu if you can.

@joshhumphreys
Copy link

Hello,

We have used the 'add to a list' pattern alongside pagination recently on our HMRC project. Here are some of the recent findings from our latest round of user research with 6 users. For context, the user is taken to this page after uploading a file containing member information. There is also the option for the user to enter each member manually.

  • All users expected and understood that this list was the data from their csv file upload, additionally, they understood 'remove' and what they would achieve by clicking this
  • Number detailing how many members are on the list was utilised by users as a reference to confirm they uploaded correct file
  • One user skim read 'do you want to upload another member details file?' and assumed it was 'do you want to continue' and clicked 'yes' which led to confusion when they were asked to upload another file
  • Administrators managing lists with large number of members said that they would not use the 'search' or 'change' tool and would prefer to directly change anything within their own spreadsheets as opposed to within HMRC websites
  • Some users expressed a desire for the list of members to be alphabetised for easy scanning

Add members

@BoabaFett
Copy link

BoabaFett commented Jan 18, 2024

Minor point. We've tested add to a list in a lot of research sessions and users easily understand it.
We have a use case where we want to show both a key and a value on the same row - eg The warehouse, 18 GG1 8YY and an amount paid for the building, £123.

image

This works when I use the hmrc-summary-list__key class: twice.

<dt class="govuk-summary-list__key govuk-!-font-weight-regular hmrc-summary-list__key">
   The warehouse, 18 GG1 8YY
</dt>
<dd class="govuk-summary-list__key govuk-!-font-weight-regular hmrc-summary-list__key">
     £123
</dd>

However, for the second value it seems like I should use <dd class="govuk-summary-list__value govuk-!-font-weight-regular hmrc-summary-list__value">

I don't think this is available in the hmrc CSS though. Suggestions welcome.

@shabana-ali
Copy link

shabana-ali commented Jan 29, 2024

I raised a point on the GOV.UK summary list backlog relating to 3 column widths that may need to be taken into consideration when looking at this comment regarding having key and value in add to list pattern.

@timsb
Copy link

timsb commented Jan 31, 2024

@BoabaFett Thanks for this. As you say, having two elements with the hmrc-summary-list__key class works fine. I have noticed that if there is a mixture of rows with two and three columns then the layout breaks.
We're looking into this and seeing if there are any alternative ways of styling the component.

@shabana-ali Is this comment the one you're talking about? We'll keep it in mind with any updates.

@jeana-adhoc
Copy link

Hello all - I'm researching an "add to list" pattern for my teams usage, and I'm wondering what happens when all of the list items are removed from a screen like this?

image

Does the form return to the first page of the list? Asking for them to add another one? Or, are you now removing the "delete" button if there is only one list item?

@a184studio
Copy link

Hi Jeana,

If there is no data in a list then there should be not be a list. It should probably be an opening question of ‘do you need to add an XYZ’ (optional) or ‘Add XYZ’ (mandatory)

If 3 data items were in a list, and all removed, post submission of final entry, you should be taken to ‘do you need to add XYZ’ (if optional) or ‘no XYZs added, Add XYZ’ if mandatory

@jeana-adhoc
Copy link

Thanks @a184studio - You're touching on the struggle we're having. If all of the items are removed (with destructive modal notifications), but at least one is required, I think I want to return the user to the first page of the "list" where they add items, and add an alert saying at least one is required. OR I could leave them on the same page where the list was previously add an alert saying "no xyz's were added. Add XYZ", and then the continue button leads them to the first page of the list data collection. I can see pros and cons of both.

@a184studio
Copy link

Hi @jeana-adhoc

For me if it’s mandatory to add at least one item to a list then it’s a mandatory action. That has optional additions and there for can only becomes a ‘list’ if more than one item is entered.

For example.

Q1 > Q2 > Q3: Add ‘mandatory item’ > Q4: Do you need to add anymore items Y/N

N > Q5

Y Q4a: Add Item2 >

List page (Mini checkYourAnswers)
CYA: Do you need to add another data item Y/N

if you remove Item2 one remains.
if you removed item2 and item1 then no items remain, prior to that you will need to add a page to say.

“You are about to remove the last item, the service needs at least one item to continue”

I would say, investigate the CardPatten with AddChange and remove cards from a Mini CYA page

I’m out of the country at the minute but happy to talk more when I return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests