Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to a list #31

Open
rpowis opened this issue Jan 31, 2017 · 14 comments

Comments

8 participants
@rpowis
Copy link
Member

commented Jan 31, 2017

Screenshot

image

@gavinwye gavinwye assigned gavinwye and adamliptrot-oc and unassigned gavinwye Sep 6, 2017

@gavinwye gavinwye moved this from Backlog to In progress in HMRC Design Patterns backlog Sep 6, 2017

@stevenaproctor

This comment has been minimized.

Copy link

commented Oct 17, 2017

@gavinwye This looks like a combination of #25, #23 and #35 but the hint text is in the wrong place and the month looks like it should be written in full.

@gavinwye gavinwye moved this from In progress to Ready in HMRC Design Patterns backlog Oct 18, 2017

@gavinwye gavinwye moved this from Ready to Backlog in HMRC Design Patterns backlog Nov 8, 2017

@stevenaproctor stevenaproctor changed the title Add another Add to a list Mar 7, 2018

@jennifer-hodgson

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

This from CATO
cato

@jennifer-hodgson

This comment has been minimized.

@gordonmcmullan

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2018

Discussion Summary from the hackday

img_20180316_150216

img_20180312_133137

@jennifer-hodgson jennifer-hodgson self-assigned this Mar 16, 2018

@adamliptrot-oc

This comment has been minimized.

Copy link

commented Mar 16, 2018

image
Here an initial screen indicates the user is about to interact with an add-to-a-list pattern. They then add the first item. A small check-your-answers is displayed to confirm the data collected from adding the item before returning the user to the list (now populated with the item along with change and remove options) and asking the user if they want to add more or continue with the rest of the journey

@stevenaproctor

This comment has been minimized.

Copy link

commented Mar 23, 2018

@jennifer-hodgson jennifer-hodgson moved this from Backlog to Review in HMRC Design Patterns backlog May 10, 2018

@gordonmcmullan gordonmcmullan moved this from Review to Published in HMRC Design Patterns backlog Jun 14, 2018

@stevenaproctor

This comment has been minimized.

Copy link

commented Oct 10, 2018

Similar to Edit a list on the GOV.UK Design System backlog. I think it is similar enough to merge.

@jennifer-hodgson

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2018

Yup - think we should upstream our variant

@jdworks

This comment has been minimized.

Copy link

commented Oct 26, 2018

We tested this pattern (with a couple of slight changes) with agents last week:

screenshot 2018-10-26 at 13 34 58

Context: agents use the service to build an authorisation request for their client, and they add tax services to the request one at a time before sending it to their client.

We needed to include the name of the client and the service they were requesting authorisation for in the table for it to make sense to the user. Regarding CTA's, 'change' is not an option since it's not technically possible to change the request once it's been created, though it can be deleted before the agent sends to the client. Contrary to the screengrab above, the version we tested used the word 'delete' instead of 'remove', though after the testing we changed the wording to the softer sounding 'remove' as we felt it fitted the use case better: "remove a pending request" rather than "delete a pending request". We'll see how this tests in the next few weeks.

Overall the pattern worked well. Users understood the page straight away and were happy with what the table was showing, and understood the calls to action.

@jennifer-hodgson

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.

I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

@mikeash82

This comment has been minimized.

Copy link

commented Nov 27, 2018

Added to the Edit a list pattern on GOV.UK issues backlog

@mikeash82 mikeash82 closed this Nov 27, 2018

@jennifer-hodgson

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2018

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.

I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

Comment seems to be still appearing for now.
My concern is that it's confusing for users and spreads things across two design systems. I know it's an interim solution before we publish publicly but I think we should avoid.

@mikeash82

This comment has been minimized.

Copy link

commented Nov 27, 2018

Published on HMRC design library
http://hmrc.github.io/assets-frontend/patterns/add-to-a-list/index.html

Is this the wrong link? If not, I think it's confusing to be linking off to the old HMRC Design System site.
I have deleted the comment, but i also linked to the old design system on the GOV.UK issue. I dont think we can send links to our prototype on github.

Comment seems to be still appearing for now.
My concern is that it's confusing for users and spreads things across two design systems. I know it's an interim solution before we publish publicly but I think we should avoid.

yes good point. We can add links when we have a more permanent home for out design library.

@jennifer-hodgson

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

Reopening this as we're working on this in-house in response to discussions within the design community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.