-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEC-1058 json library swap #36
Conversation
app/uk/gov/hmrc/hecapplicantfrontend/models/HECTaxCheckData.scala
Outdated
Show resolved
Hide resolved
@AndyHWChung @priyankadhiman3006 I've added tests for the readers/writes in this commit, can you review them, thanks |
Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day? |
9587e37
to
07b233f
Compare
test/uk/gov/hmrc/hecapplicantfrontend/models/HECTaxCheckDataSpec.scala
Outdated
Show resolved
Hide resolved
Good question, I think it's better to do them all together @AndyHWChung ? |
Yeah, we should merge everything together including updates to |
I'll keep this in |
Then again, other code will keep on piling and you have to do rebase and stuff. i think we should divide and conquer :) happy to help |
No description provided.