PLATUI-2942: Upgrade library to govuk-frontend v5.3.0 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-bowden
force-pushed
the
PLATUI-2943_adr_password_field
branch
from
26a510c
to
72b49aa
Compare
|
…from govuk-frontend v5.3.9
kyle-bowden
force-pushed
the
PLATUI-2943_adr_password_field
branch
from
72b49aa
to
40f0c85
Compare
|
|
||
| * Good, because it aligns our resources with current needs and reduces overhead. | ||
| * Good, because it leaves room to adapt based on future demand. | ||
| * Bad, because teams with immediate needs must find alternative solutions. |
There was a problem hiding this comment.
LGTM extra context on this is "where we think that it would not be too troublesome / intensive for people to implement the markup themselves if they need to because it's a standard input and button some extra classes and attributes"
kyle-bowden
force-pushed
the
PLATUI-2943_adr_password_field
branch
from
edaf8f2
to
4eda4d5
Compare
ellamdav
changed the title
|
| } | ||
| } | ||
| @dataAttributes = @{ | ||
| val maybeDataAttributes = ListMap( |
There was a problem hiding this comment.
do we still need to use a ListMap here? The attrs as string OR map[string, string] is really confusing to work around - looks ok, feels like it's going to be worth seeing if we can do a better comparison when testing against output rendered by govuk stuff, can imagine more an more excluded / flakey tests 😵
There was a problem hiding this comment.
IIRC ListMap fixed some failing unit tests, and yes - it's awful 😅
kyle-bowden
force-pushed
the
PLATUI-2943_adr_password_field
branch
from
3f3c459
to
21521f2
Compare
oscarduignan
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.