-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLATUI-2942: Upgrade library to govuk-frontend v5.3.0 #292
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
40f0c85
PLATUI-2944: Add ADR to record decision on excluding password fields …
kyle-bowden 4eda4d5
PLATUI-2942: Release new version of play-frontend-hmrc that has govuk…
kyle-bowden 4c58bdb
PLATUI-2897 wire up afterInput in GovukCharacterCount; scalafmt
ellamdav b54f03d
PLATUI-2897 add some missing viewmodel aliases
ellamdav 58c7e0c
PLATUI-2943 exclude character count tests that currently fail under S…
ellamdav 21521f2
PLATUI-2943 bump sbt-auto-build
ellamdav File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# Defer Inclusion of Password Field from govuk-frontend v5.3.0 | ||
|
||
* Status: accepted | ||
* Date: 2024-08-04 | ||
|
||
## Context and Problem Statement | ||
|
||
With the release of govuk-frontend v5.3.0, which includes a password field, we are considering whether to integrate this feature into our frontend library. Given that authentication for most services is handled by a central service (e.g., GG or the upcoming OLFG), the need for a library component for password fields may not be widespread. There are also considerations around the engineering cost of creating and maintaining such a component. | ||
|
||
## Decision Drivers | ||
|
||
* Centralized authentication services reducing the need for a password field component | ||
* Engineering cost of maintenance and development | ||
* Potential future demand for this component | ||
|
||
## Considered Options | ||
|
||
* Immediately include the password field feature from govuk-frontend v5.3.0 | ||
* Defer the inclusion of the password field feature until there is a demonstrated need | ||
|
||
## Decision Outcome | ||
|
||
Chosen option: "Defer the inclusion of the password field feature until there is a demonstrated need", because it allows us to focus on components with a clear demand and reduces the maintenance burden. This decision is reversible, and we remain open to revisiting it should a significant need for this component arise from our services. | ||
|
||
### Positive Consequences | ||
|
||
* Keeps the library focused on widely used components | ||
* Reduces unnecessary maintenance and development work | ||
* Flexible approach that can adapt to future demands | ||
|
||
### Negative Consequences | ||
|
||
* Teams needing the password field immediately may have to implement their own solutions | ||
|
||
## Pros and Cons of the Options | ||
|
||
### Immediately include the password field feature | ||
|
||
* Good, because it provides immediate feature completeness. | ||
* Bad, because it likely adds an unused feature for most teams, increasing maintenance overhead. | ||
|
||
### Defer the inclusion of the password field feature | ||
|
||
* Good, because it aligns our resources with current needs and reduces overhead. | ||
* Good, because it leaves room to adapt based on future demand. | ||
* Bad, because teams with immediate needs must find alternative solutions. | ||
|
||
## Links | ||
|
||
* [govuk-frontend v5.3.0 Release Notes](https://github.com/alphagov/govuk-frontend/releases/tag/v5.3.0) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM extra context on this is "where we think that it would not be too troublesome / intensive for people to implement the markup themselves if they need to because it's a standard input and button some extra classes and attributes"