[SDT-38] Get assetsPrefix directly from play conf #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmypixel
reviewed
Oct 28, 2016
| lazy val assetsPrefix = assetsUrl + assetsVersion | ||
| } | ||
|
|
||
| object AssetsPrefix extends AssetsPrefix |
There was a problem hiding this comment.
Naming wise - the AssetsPrefix file and associated object, trait could be re-named AssetsConfig. It looks a little funny when called in the view as @AssetsPrefix.assetsPrefix
|
LGTM 👍 |
This was referenced Oct 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces a standardised way of defining assets config in frontends and moves away from the run mode structure.
This is for review by @hmrc/platops