Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picsure 16 patient mapping data #63

Merged
merged 5 commits into from
May 17, 2018
Merged

Conversation

calypsomatic
Copy link
Contributor

Unfortunately it's a little hard to tell what changes happened in I2B2XMLResourceImplementation, but it's mostly just moving declarations of variables a little bit and wrapping some of the logic in an if statement.

}

@Override
public Result runQuery(User user,Query query, Result result) throws ResourceInterfaceException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if just super(), you don't actually need to override it

for (PidType ps : patientDataResponse.getPatientData().getPidSet().getPid()){
if (this.sourceWhiteList.contains(ps.getPatientId().getSource())){
mrs.appendRow();
mrs.updateString("Patient Id", ps.getPatientId().getValue());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see screenshots: image
which one should we look into?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

direct from i2b2 org about PID:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need both to come back, so you would pseu-do something like this:

select: Hospital-1 and Hospital-5
where: patients have lab results of some kind

and get something like this in return:

patient_id, Hospital-1, Hospital-5
100000001, 2000001961, 3000001821
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of one column of just the patient id, we need multiple columns, where the heading of the columns is the patient_map_id source?? Meaning multiple columns with the same heading? This needs a lot more explanation, and to be in the ticket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are clear now 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! All updated.

@namdets namdets merged commit 28857a3 into master May 17, 2018
@namdets namdets deleted the picsure-16-patient-mapping-data branch May 17, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants