Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vite #506

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Upgrade Vite #506

merged 4 commits into from
Sep 24, 2021

Conversation

ilan-gold
Copy link
Collaborator

@ilan-gold ilan-gold commented Sep 23, 2021

Fixes #303 (I think)

Change List

  • Upgrade Vite to ~2.5.4

Checklist

  • Update JSdoc types if there is any API change.
  • Make sure Avivator works as expected with your change.

import { getOmePixelSourceMeta, guessTileSize } from './lib/utils';
import type Pool from './lib/Pool';
import type { OmeTiffIndexer } from './lib/indexers';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error about the type not being found without this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went back to try it again and get the actual text of the error and couldn't reproduce so reverted this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok I was looking in the wrong place. I get

Uncaught SyntaxError: import not found: OmeTiffIndexer

in the browser console.

@ilan-gold
Copy link
Collaborator Author

@andreasg123 Could you try this out?

@andreasg123
Copy link
Contributor

@ilan-gold, thanks for doing this. As far as I can tell, this works for me. However, I would have to deal with the API name change so that I couldn't test it completely.

There is one error in npm run build:

Error when using sourcemap for reporting an error: Can't resolve original location of error.
Non-existent export 'OmeTiffIndexer' is imported from src/loaders/tiff/lib/indexers.ts

@ilan-gold
Copy link
Collaborator Author

@andreasg123 Updated to resolve the import issue.

Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Tried it out!

@ilan-gold ilan-gold merged commit b32bb85 into master Sep 24, 2021
@ilan-gold ilan-gold deleted the ilan-gold/upgrade_vite branch September 24, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json points to dist file that trips up Next.js
3 participants