feat(loaders): Drop fast-xml-parser
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzt
force-pushed
the
manzt/drop-fast-xml-parser
branch
from
e06b30a
to
eec8de5
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
fast-xml-parserdependency in favor of usingDOMParserWeb API.All the examples and tests are passing, but I don't think Avivator makes use of much of the metadata. This is probably somewhere that snapshot testing could help us a bit. @keller-mark, I don't anticipate this to be a breaking change but maybe there is something I'm missing wrt what Vitessce relies on (if any) of the parsed and modified OME-XML metadata.
Fixes #
Background
Change List
Checklist