-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotGradient cuts off original data #48
Comments
Thanks, I also noted this and fixed manually for my own purposes... We
should fix that more properly for the package. Jari, if you have time,
you could make it?
…On 18.6.2020 10.53, stephanJG wrote:
Hi,
I recently realized that the "plotGradient" function is cutting off
original data. The problem is that the ylim is set to min and max of
the predictions, not the original data.
Best
Jörg
*plotGradient*
plotGr
<https://user-images.githubusercontent.com/65352673/84993230-4c5b4400-b149-11ea-8a43-be4078760ad4.png>
*ggplot*
image
<https://user-images.githubusercontent.com/65352673/84992007-95aa9400-b147-11ea-9279-43b028b67459.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#48>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIYMZTNMHGBJLT2CHPCVW3RXHBWNANCNFSM4OBKEROQ>.
|
@ovaskain : I'll do this. I haven't peeked at the code yet, but sounds pretty trivial a fix. |
It seems that the max was correctly set with data, but the line of code for setting min was just forgotten. Should be fixed with commit 91874d6. |
PS: as I have been ask for how to plot with ggplot here some code #Percentiles used in calculation #names #loop over all exp vars |
Hi,
I recently realized that the "plotGradient" function is cutting off original data. The problem is that the ylim is set to min and max of the predictions, not the original data.
Best
Jörg
plotGradient
ggplot
The text was updated successfully, but these errors were encountered: