-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger's yaml file for employees #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this. Sorry for not responding on time. I didn't quickly see this. If you need to get response faster it might be faster through slack.
I noticed you ignored the templates directory (.github) was that necessary?
Awesome breakdown of the address but unfortunately to make it simple we are using a string
The hire_date is a date field. I believe in this format -> type: string format: date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Awesome!
I wasn't too sure as to what the address type is so I made it into an object with its own properties.
Also, I made hireDate to be an integer, assuming that the date is stored as milliseconds.
Please let me know if I should make any changes.