Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger's yaml file for employees #30

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Swagger's yaml file for employees #30

merged 6 commits into from
Jun 10, 2020

Conversation

simply-alliv
Copy link
Contributor

I wasn't too sure as to what the address type is so I made it into an object with its own properties.

Also, I made hireDate to be an integer, assuming that the date is stored as milliseconds.

Please let me know if I should make any changes.

@simply-alliv simply-alliv linked an issue Jun 10, 2020 that may be closed by this pull request
1 task
Copy link
Member

@dave-ok dave-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this. Sorry for not responding on time. I didn't quickly see this. If you need to get response faster it might be faster through slack.
I noticed you ignored the templates directory (.github) was that necessary?
Awesome breakdown of the address but unfortunately to make it simple we are using a string
The hire_date is a date field. I believe in this format -> type: string format: date

Copy link
Member

@dave-ok dave-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Awesome!

@dave-ok dave-ok added this to In progress in Employee Records Microservice Board via automation Jun 10, 2020
@dave-ok dave-ok merged commit 95136e9 into hngi:develop Jun 10, 2020
Employee Records Microservice Board automation moved this from In progress to Done Jun 10, 2020
@simply-alliv simply-alliv deleted the jsdocs branch June 10, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Swagger API Docs Task 1
2 participants